Update perspective paint properties on perspective-origin changes

Update perspective paint properties on perspective-origin changes

This patch  fixes under-invalidation when perspective-origin changes
due to an object's size changing (similar to [1]). This patch also
updates the comment added in [1] to note that we only need to
invalidate if relative lengths are used.

[1] https://crrev.com/700fe29521a77a433f07b85fda61a35609c46cf2

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/fc7eae11d98828abba746ba86a96ee9fc83a1741
Cr-Commit-Position: refs/heads/master@{#440568}

[pdr., 2016-12-22 21:49:24]

pdr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[Xianzhu, 2016-12-22 21:55:15]

lgtm

https://codereview.chromium.org/2602453002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2602453002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:1717: // with relative
lengths (e.g., percentage).
Nit: Other transform components can also be relative lengths, e.g.
translateX(10%), which is also covered by this condition. Please update comments
to mention this.

[pdr., 2016-12-22 22:06:44]

On 2016/12/22 at 21:55:15, wangxianzhu wrote:
> lgtm
> 
>
https://codereview.chromium.org/2602453002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):
> 
>
https://codereview.chromium.org/2602453002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/layout/LayoutBox.cpp:1717: // with relative
lengths (e.g., percentage).
> Nit: Other transform components can also be relative lengths, e.g.
translateX(10%), which is also covered by this condition. Please update comments
to mention this.

Good idea, done.

PTAL, and CQ if it looks good to you.

[Xianzhu, 2016-12-22 22:14:09]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-22 22:14:10]

lgtm

[commit-bot: I haz the power, 2016-12-22 22:14:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 01:03:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482444849920390,
"parent_rev": "40cdce275fb6d9a056a51dc11fb65af8c6513246", "commit_rev":
"36c24c6f3345f0e8a688d50abf0ef329b32e15d0"}

[commit-bot: I haz the power, 2016-12-23 01:03:46]

Description was changed from

==========
Update perspective paint properties on perspective-origin changes

This patch  fixes under-invalidation when perspective-origin changes
due to an object's size changing (similar to [1]). This patch also
updates the comment added in [1] to note that we only need to
invalidate if relative lengths are used.

[1] https://crrev.com/700fe29521a77a433f07b85fda61a35609c46cf2

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Update perspective paint properties on perspective-origin changes

This patch  fixes under-invalidation when perspective-origin changes
due to an object's size changing (similar to [1]). This patch also
updates the comment added in [1] to note that we only need to
invalidate if relative lengths are used.

[1] https://crrev.com/700fe29521a77a433f07b85fda61a35609c46cf2

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2602453002
==========

[commit-bot: I haz the power, 2016-12-23 01:03:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-23 01:07:02]

Description was changed from

==========
Update perspective paint properties on perspective-origin changes

This patch  fixes under-invalidation when perspective-origin changes
due to an object's size changing (similar to [1]). This patch also
updates the comment added in [1] to note that we only need to
invalidate if relative lengths are used.

[1] https://crrev.com/700fe29521a77a433f07b85fda61a35609c46cf2

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2602453002
==========

to

==========
Update perspective paint properties on perspective-origin changes

This patch  fixes under-invalidation when perspective-origin changes
due to an object's size changing (similar to [1]). This patch also
updates the comment added in [1] to note that we only need to
invalidate if relative lengths are used.

[1] https://crrev.com/700fe29521a77a433f07b85fda61a35609c46cf2

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/fc7eae11d98828abba746ba86a96ee9fc83a1741
Cr-Commit-Position: refs/heads/master@{#440568}
==========

[commit-bot: I haz the power, 2016-12-23 01:07:03]

Patchset 4 (id:??) landed as
https://crrev.com/fc7eae11d98828abba746ba86a96ee9fc83a1741
Cr-Commit-Position: refs/heads/master@{#440568}