third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp - Issue 2602453002: Update perspective paint properties on perspective-origin changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2602453002: Update perspective paint properties on perspective-origin changes (Closed)

Patch Set: Update comment, add a relative length update test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

index d566bce62457849e08dff4dd1d9c86918207e0e1..239e70dfd1ed9324f0f1653d7568fe29e1f3307a 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

@@ -626,6 +626,8 @@ void PaintPropertyTreeBuilder::updateOverflowClip(

static FloatPoint perspectiveOrigin(const LayoutBox& box) {

const ComputedStyle& style = box.styleRef();

+ // Perspective origin has no effect without perspective.

+ DCHECK(style.hasPerspective());

FloatSize borderBoxSize(box.size());

return FloatPoint(

floatValueForLength(style.perspectiveOriginX(), borderBoxSize.width()),