A little more work on the DDC bot script.

A little more work on the DDC bot script.

It runs and passes on my Mac now even when I don't have a local /gen/
directory, which was the main missing piece.

R=vsm@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/87139576e906dd751f75d0bfe718002f2a4689f1

[Bob Nystrom, 2016-12-22 21:34:52]

rnystrom@google.com changed reviewers:
+ vsm@google.com, whesse@google.com

[vsm, 2017-01-03 17:57:26]

lgtm

[Bill Hesse, 2017-01-03 20:09:21]

LGTM!

https://codereview.chromium.org/2602443002/diff/1/tools/bots/ddc_tests.py
File tools/bots/ddc_tests.py (right):

https://codereview.chromium.org/2602443002/diff/1/tools/bots/ddc_tests.py#new...
tools/bots/ddc_tests.py:26: with bot.BuildStep('Compile packages used by tests
to JS'):
These bot.BuildStep calls are doing nothing, because this entire script is run
within a single build step, and the buildstep comments these introduce are
escaped by the framework before being put in the logs.

Once we have this working, we can make separate steps in the recipe for the
separate steps in this script, but right now, this is just putting !@@@BUILDSTEP
lines in the log.

[Bob Nystrom, 2017-01-03 22:36:50]

Description was changed from

==========
A little more work on the DDC bot script.

It runs and passes on my Mac now even when I don't have a local /gen/
directory, which was the main missing piece.
==========

to

==========
A little more work on the DDC bot script.

It runs and passes on my Mac now even when I don't have a local /gen/
directory, which was the main missing piece.

R=vsm@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/87139576e906dd751f75d0bfe718002f2a4689f1
==========

[Bob Nystrom, 2017-01-03 22:36:53]

Committed patchset #1 (id:1) manually as
87139576e906dd751f75d0bfe718002f2a4689f1 (presubmit successful).

[Bob Nystrom, 2017-01-03 22:37:16]

https://codereview.chromium.org/2602443002/diff/1/tools/bots/ddc_tests.py
File tools/bots/ddc_tests.py (right):

https://codereview.chromium.org/2602443002/diff/1/tools/bots/ddc_tests.py#new...
tools/bots/ddc_tests.py:26: with bot.BuildStep('Compile packages used by tests
to JS'):
On 2017/01/03 20:09:21, Bill Hesse wrote:
> These bot.BuildStep calls are doing nothing, because this entire script is run
> within a single build step, and the buildstep comments these introduce are
> escaped by the framework before being put in the logs.
> 
> Once we have this working, we can make separate steps in the recipe for the
> separate steps in this script, but right now, this is just putting
!@@@BUILDSTEP
> lines in the log.

Eliminated them, with prejudice.