A little more work on the DDC bot script.

tools/bots/ddc_tests.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import os
 import os.path
 import shutil
 import sys
 import subprocess
 
 import bot
 import bot_utils
 
 utils = bot_utils.GetUtils()
 
 BUILD_OS = utils.GuessOS()
 
 (bot_name, _) = bot.GetBotName()
 CHANNEL = bot_utils.GetChannelFromName(bot_name)
 
 if __name__ == '__main__':
   with utils.ChangedWorkingDirectory('pkg/dev_compiler'):
-    with bot.BuildStep('npm install'):
+    # These steps mirror pkg/dev_compiler/tool/test.sh.
+    with bot.BuildStep('Compile packages used by tests to JS'):

[Bill Hesse, 2017/01/03 20:09:21]

These bot.BuildStep calls are doing nothing, because this entire script is run
within a single build step, and the buildstep comments these introduce are
escaped by the framework before being put in the logs.

Once we have this working, we can make separate steps in the recipe for the
separate steps in this script, but right now, this is just putting !@@@BUILDSTEP
lines in the log.

[Bob Nystrom, 2017/01/03 22:37:16]

Eliminated them, with prejudice.

+      bot.RunProcess([
+        utils.CheckedInSdkExecutable(), 'tool/build_pkgs.dart', 'test'
+      ])
+
+    with bot.BuildStep('Run unit tests and compile tests to JS'):
+      bot.RunProcess([utils.CheckedInSdkExecutable(), 'test/all_tests.dart'])
+
+    # These steps mirror pkg/dev_compiler/tool/browser_test.sh.
+    with bot.BuildStep('Install npm packages needed by JS test runner'):
       bot.RunProcess(['npm', 'install'])
 
-    with bot.BuildStep('Compile tests and run unit tests'):
-      bot.RunProcess([utils.CheckedInSdkExecutable(), 'test/all_tests.dart'])
-
     with bot.BuildStep('Execute compiled tests'):
       bot.RunProcess(['npm', 'test'])