Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: tools/bots/ddc_tests.py

Issue 2602443002: A little more work on the DDC bot script. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/ddc_tests.py
diff --git a/tools/bots/ddc_tests.py b/tools/bots/ddc_tests.py
index fc6830f6df215d4e506a178927dedc25b252d825..3f4e3dcebd7f632b31f1294ebf10d1910d4ecb29 100644
--- a/tools/bots/ddc_tests.py
+++ b/tools/bots/ddc_tests.py
@@ -22,11 +22,18 @@ CHANNEL = bot_utils.GetChannelFromName(bot_name)
if __name__ == '__main__':
with utils.ChangedWorkingDirectory('pkg/dev_compiler'):
- with bot.BuildStep('npm install'):
- bot.RunProcess(['npm', 'install'])
+ # These steps mirror pkg/dev_compiler/tool/test.sh.
+ with bot.BuildStep('Compile packages used by tests to JS'):
Bill Hesse 2017/01/03 20:09:21 These bot.BuildStep calls are doing nothing, becau
Bob Nystrom 2017/01/03 22:37:16 Eliminated them, with prejudice.
+ bot.RunProcess([
+ utils.CheckedInSdkExecutable(), 'tool/build_pkgs.dart', 'test'
+ ])
- with bot.BuildStep('Compile tests and run unit tests'):
+ with bot.BuildStep('Run unit tests and compile tests to JS'):
bot.RunProcess([utils.CheckedInSdkExecutable(), 'test/all_tests.dart'])
+ # These steps mirror pkg/dev_compiler/tool/browser_test.sh.
+ with bot.BuildStep('Install npm packages needed by JS test runner'):
+ bot.RunProcess(['npm', 'install'])
+
with bot.BuildStep('Execute compiled tests'):
bot.RunProcess(['npm', 'test'])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698