[ARM] Add vcge, vcgt instructions to assembler.

[ARM] Add vcge, vcgt  instructions to assembler.
- Floating point, signed, and unsigned.
- Disassembler, simulator support too.
LOG=N
BUG=v8:4124
Review-Url: https://codereview.chromium.org/2602293002
Cr-Commit-Position: refs/heads/master@{#42262}
Committed: https://chromium.googlesource.com/v8/v8/+/e46893c6c42213646cc0f41f74a7141adcd7e01c

[bbudge, 2017-01-02 14:21:30]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-02 14:21:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2017-01-06 11:48:04]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 11:48:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2017-01-06 11:48:25]

bbudge@chromium.org changed reviewers:
+ martyn.capewell@arm.com

[commit-bot: I haz the power, 2017-01-06 12:13:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 12:13:42]

Dry run: This issue passed the CQ dry run.

[martyn.capewell, 2017-01-06 19:10:21]

https://codereview.chromium.org/2602293002/diff/20001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):

https://codereview.chromium.org/2602293002/diff/20001/src/arm/assembler-arm.c...
src/arm/assembler-arm.cc:4291: static Instr EncodeNeonCompareOp(const
QwNeonRegister dst,
Why not pass a Condition argument and encapsulate all of the comparison encoding
in these functions?

https://codereview.chromium.org/2602293002/diff/20001/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):

https://codereview.chromium.org/2602293002/diff/20001/src/arm/simulator-arm.c...
src/arm/simulator-arm.cc:4014: int8_t* s1 = reinterpret_cast<int8_t*>(src1);
It's worth implementing some new get/set_q_register() functions that write into
arrays of the correct type for your operation, ie. get_q_register(int, int8_t*),
get_q_register(int, uint8_t*), then these casts can all be put in one place.

[bbudge, 2017-01-10 11:17:11]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 11:17:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2017-01-10 11:17:52]

https://codereview.chromium.org/2602293002/diff/20001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):

https://codereview.chromium.org/2602293002/diff/20001/src/arm/assembler-arm.c...
src/arm/assembler-arm.cc:4291: static Instr EncodeNeonCompareOp(const
QwNeonRegister dst,
On 2017/01/06 19:10:21, martyn.capewell wrote:
> Why not pass a Condition argument and encapsulate all of the comparison
encoding
> in these functions?

Done.

https://codereview.chromium.org/2602293002/diff/20001/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):

https://codereview.chromium.org/2602293002/diff/20001/src/arm/simulator-arm.c...
src/arm/simulator-arm.cc:4014: int8_t* s1 = reinterpret_cast<int8_t*>(src1);
On 2017/01/06 19:10:21, martyn.capewell wrote:
> It's worth implementing some new get/set_q_register() functions that write
into
> arrays of the correct type for your operation, ie. get_q_register(int,
int8_t*),
> get_q_register(int, uint8_t*), then these casts can all be put in one place.

Yes, good idea. Done.

[commit-bot: I haz the power, 2017-01-10 11:53:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 11:53:24]

Dry run: This issue passed the CQ dry run.

[martyn.capewell, 2017-01-10 15:13:55]

lgtm

It might be worth pulling vceq into EncodeNeonCompareOp, but that can wait for
vcle/t, if you need them.

[bbudge, 2017-01-11 11:20:23]

On 2017/01/10 15:13:55, martyn.capewell wrote:
> lgtm
> 
> It might be worth pulling vceq into EncodeNeonCompareOp, but that can wait for
> vcle/t, if you need them.

vceq and vcge/gt seemed different enough that I didn't factor that far. I don't
plan to implement vcle/lt (they're just pseudo-ops since we can get the same
effect by reversing the source operands, right?)

[martyn.capewell, 2017-01-11 13:07:04]

On 2017/01/11 11:20:23, bbudge_ooo_until_mid_jan wrote:

> vceq and vcge/gt seemed different enough that I didn't factor that far. I
don't
> plan to implement vcle/lt (they're just pseudo-ops since we can get the same
> effect by reversing the source operands, right?)

True, and that reversing might happen earlier in the pipeline, so the code
generator never sees it.

[bbudge, 2017-01-12 10:02:24]

The CQ bit was checked by bbudge@chromium.org

[commit-bot: I haz the power, 2017-01-12 10:02:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 10:04:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 10:04:06]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/18940)

[bbudge, 2017-01-12 10:51:36]

The CQ bit was checked by bbudge@chromium.org

[bbudge, 2017-01-12 10:51:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
martyn.capewell@arm.com
Link to the patchset: https://codereview.chromium.org/2602293002/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-01-12 10:51:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 11:20:09]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484218296694390,
"parent_rev": "d23e7d2f813fecfa7aff73621b3a26d11805dfd4", "commit_rev":
"e46893c6c42213646cc0f41f74a7141adcd7e01c"}

[commit-bot: I haz the power, 2017-01-12 11:20:14]

Description was changed from

==========
[ARM] Add vcge, vcgt  instructions to assembler.
- Floating point, signed, and unsigned.
- Disassembler, simulator support too.
LOG=N
BUG=v8:4124
==========

to

==========
[ARM] Add vcge, vcgt  instructions to assembler.
- Floating point, signed, and unsigned.
- Disassembler, simulator support too.
LOG=N
BUG=v8:4124

Review-Url: https://codereview.chromium.org/2602293002
Cr-Commit-Position: refs/heads/master@{#42262}
Committed:
https://chromium.googlesource.com/v8/v8/+/e46893c6c42213646cc0f41f74a7141adcd...
==========

[commit-bot: I haz the power, 2017-01-12 11:20:15]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/e46893c6c42213646cc0f41f74a7141adcd...