Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2602293002: [ARM] Add vcge, vcgt instructions to assembler. (Closed)

Created:
3 years, 11 months ago by bbudge
Modified:
3 years, 11 months ago
Reviewers:
martyn.capewell
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM] Add vcge, vcgt instructions to assembler. - Floating point, signed, and unsigned. - Disassembler, simulator support too. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2602293002 Cr-Commit-Position: refs/heads/master@{#42262} Committed: https://chromium.googlesource.com/v8/v8/+/e46893c6c42213646cc0f41f74a7141adcd7e01c

Patch Set 1 #

Patch Set 2 : Fix some assembler comments. #

Total comments: 4

Patch Set 3 : Rebase. #

Patch Set 4 : Add Condition argument to encode fns. #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -10 lines) Patch
M src/arm/assembler-arm.h View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 2 3 4 3 chunks +66 lines, -2 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 2 3 4 2 chunks +29 lines, -0 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 2 3 4 8 chunks +127 lines, -6 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 2 3 4 5 chunks +57 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
bbudge
3 years, 11 months ago (2017-01-06 11:48:26 UTC) #6
martyn.capewell
https://codereview.chromium.org/2602293002/diff/20001/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): https://codereview.chromium.org/2602293002/diff/20001/src/arm/assembler-arm.cc#newcode4291 src/arm/assembler-arm.cc:4291: static Instr EncodeNeonCompareOp(const QwNeonRegister dst, Why not pass a ...
3 years, 11 months ago (2017-01-06 19:10:21 UTC) #9
bbudge
https://codereview.chromium.org/2602293002/diff/20001/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): https://codereview.chromium.org/2602293002/diff/20001/src/arm/assembler-arm.cc#newcode4291 src/arm/assembler-arm.cc:4291: static Instr EncodeNeonCompareOp(const QwNeonRegister dst, On 2017/01/06 19:10:21, martyn.capewell ...
3 years, 11 months ago (2017-01-10 11:17:52 UTC) #12
martyn.capewell
lgtm It might be worth pulling vceq into EncodeNeonCompareOp, but that can wait for vcle/t, ...
3 years, 11 months ago (2017-01-10 15:13:55 UTC) #15
bbudge
On 2017/01/10 15:13:55, martyn.capewell wrote: > lgtm > > It might be worth pulling vceq ...
3 years, 11 months ago (2017-01-11 11:20:23 UTC) #16
martyn.capewell
On 2017/01/11 11:20:23, bbudge_ooo_until_mid_jan wrote: > vceq and vcge/gt seemed different enough that I didn't ...
3 years, 11 months ago (2017-01-11 13:07:04 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602293002/60001
3 years, 11 months ago (2017-01-12 10:02:37 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/30663) v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 11 months ago (2017-01-12 10:04:06 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602293002/80001
3 years, 11 months ago (2017-01-12 10:51:47 UTC) #24
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 11:20:15 UTC) #27
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/e46893c6c42213646cc0f41f74a7141adcd...

Powered by Google App Engine
This is Rietveld 408576698