Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2602103003: Remove the _cpp_sources target from mojom. (Closed)

Created:
3 years, 11 months ago by Sam McNally
Modified:
3 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, anandc+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, blink-reviews, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, einbinder+watch-test-runner_chromium.org, gcasto+watch-blimp_chromium.org, haraken, jam, jochen+watch_chromium.org, khushalsagar+watch-blimp_chromium.org, kinuko+watch, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-content_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, qsr+mojo_chromium.org, scf+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, tfarina, toyoshim+midi_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the _cpp_sources target from mojom. Previously, a separate ${target_name}_cpp_sources target was generated for all mojom targets because the bindings depend on some mojom files as part of their implementation. Now, the bindings directly use the generated C++ sources rather than the _cpp_sources targets and they are no longer needed. This CL removes them. Committed: https://crrev.com/64324c3ab88293eecfb30b7de45a5ad2b5a8bac8 Cr-Commit-Position: refs/heads/master@{#441532}

Patch Set 1 : #

Patch Set 2 : update/undelete comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -57 lines) Patch
M blimp/engine/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/test_runner/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 3 chunks +2 lines, -5 lines 0 comments Download
M content/public/common/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 3 chunks +6 lines, -39 lines 0 comments Download
M services/service_manager/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 29 (22 generated)
Sam McNally
3 years, 11 months ago (2017-01-03 00:45:07 UTC) #14
Ken Rockot(use gerrit already)
lgtm
3 years, 11 months ago (2017-01-03 20:26:12 UTC) #17
Sam McNally
+jam for everything outside //mojo and //services
3 years, 11 months ago (2017-01-03 22:48:47 UTC) #20
jam
lgtm
3 years, 11 months ago (2017-01-04 16:56:52 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2602103003/80001
3 years, 11 months ago (2017-01-04 22:40:55 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:80001)
3 years, 11 months ago (2017-01-05 00:40:54 UTC) #27
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 00:44:37 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64324c3ab88293eecfb30b7de45a5ad2b5a8bac8
Cr-Commit-Position: refs/heads/master@{#441532}

Powered by Google App Engine
This is Rietveld 408576698