Add options to let mojom targets override their component deps.

Add options to let mojom targets override their component deps.

BUG=636563
Committed: https://crrev.com/bd632fdc8acbab5d462ecb93512e5bad80a051fc
Cr-Commit-Position: refs/heads/master@{#441570}

[Sam McNally, 2016-12-22 06:23:48]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 06:23:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-22 06:24:20]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 06:24:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 06:27:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 06:27:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam McNally, 2016-12-22 06:33:43]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 06:34:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-22 06:34:21]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[Sam McNally, 2016-12-22 06:34:29]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-12-22 06:34:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-22 06:34:31]

Patchset #2 (id:20001) has been deleted

[Sam McNally, 2016-12-22 06:34:32]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-12-22 06:40:50]

Patchset #1 (id:60001) has been deleted

[Sam McNally, 2016-12-22 06:41:01]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 06:41:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 06:46:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 06:46:31]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Sam McNally, 2016-12-22 07:24:46]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 07:24:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-22 07:25:57]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 07:26:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 09:10:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 09:10:21]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-12-27 22:37:18]

Patchset #2 (id:100001) has been deleted

[Sam McNally, 2016-12-27 22:37:20]

Patchset #1 (id:80001) has been deleted

[Sam McNally, 2016-12-27 22:50:35]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 22:50:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-27 22:55:53]

Patchset #3 (id:160001) has been deleted

[Sam McNally, 2016-12-27 22:56:05]

Patchset #2 (id:140001) has been deleted

[Sam McNally, 2016-12-27 22:56:20]

Patchset #1 (id:120001) has been deleted

[commit-bot: I haz the power, 2016-12-27 23:54:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 23:54:43]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-12-29 09:20:14]

sammc@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-01-03 20:42:14]

Oof, this is pretty confusing, but it does seem like a reasonable solution. I
assume it needs to be updated given the removal of *_cpp_sources.

[Sam McNally, 2017-01-03 23:00:38]

On 2017/01/03 20:42:14, Ken Rockot wrote:
> Oof, this is pretty confusing, but it does seem like a reasonable solution. I
> assume it needs to be updated given the removal of *_cpp_sources.

Done. I've also changed it to always apply the dependency override so that
visibility can be used unconditionally for mojom targets.

[Ken Rockot(use gerrit already), 2017-01-04 22:46:35]

lgtm

[Sam McNally, 2017-01-05 01:58:42]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2017-01-05 01:59:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 02:09:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 02:09:57]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[Sam McNally, 2017-01-05 02:11:26]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2017-01-05 02:11:27]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2593413002/#ps240001
(title: "Fix ios")

[commit-bot: I haz the power, 2017-01-05 02:11:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 03:38:25]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1483582286529710,
"parent_rev": "05dec32bd6042f0fbcd2c6e5f1baca2be619c3ef", "commit_rev":
"386b26fae2dce24bcbfc568703b1fe9c8b7c12eb"}

[commit-bot: I haz the power, 2017-01-05 03:38:55]

Description was changed from

==========
Add options to let mojom targets override their component deps.

BUG=636563
==========

to

==========
Add options to let mojom targets override their component deps.

BUG=636563

Review-Url: https://codereview.chromium.org/2593413002
==========

[commit-bot: I haz the power, 2017-01-05 03:38:56]

Committed patchset #4 (id:240001)

[commit-bot: I haz the power, 2017-01-05 03:41:11]

Description was changed from

==========
Add options to let mojom targets override their component deps.

BUG=636563

Review-Url: https://codereview.chromium.org/2593413002
==========

to

==========
Add options to let mojom targets override their component deps.

BUG=636563

Committed: https://crrev.com/bd632fdc8acbab5d462ecb93512e5bad80a051fc
Cr-Commit-Position: refs/heads/master@{#441570}
==========

[commit-bot: I haz the power, 2017-01-05 03:41:12]

Patchset 4 (id:??) landed as
https://crrev.com/bd632fdc8acbab5d462ecb93512e5bad80a051fc
Cr-Commit-Position: refs/heads/master@{#441570}