Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2601783002: Revert of [intl] Remove redundant type checking system (Closed)

Created:
3 years, 12 months ago by Dan Ehrenberg
Modified:
3 years, 12 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [intl] Remove redundant type checking system (patchset #3 id:40001 of https://codereview.chromium.org/2591203002/ ) Reason for revert: Issue https://bugs.chromium.org/p/chromium/issues/detail?id=677055 . I'll send out a follow-on reland, as it should still be possible to eliminate the redundant type system. Original issue's description: > [intl] Remove redundant type checking system > > Previously, the Intl implementation tracked types two ways: > - In the intl_initialized_marker_symbol > - In various named properties of the intl_impl_object_symbol value > > As far as I can tell, these will never disagree with each other, > modulo bugs in Intl itself. This patch removes the second type > checking system. > > BUG=v8:5751 > > Review-Url: https://codereview.chromium.org/2591203002 > Cr-Commit-Position: refs/heads/master@{#41941} > Committed: https://chromium.googlesource.com/v8/v8/+/0d5561b64d34129e6546947255e543c219c61655 TBR=yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5751 Review-Url: https://codereview.chromium.org/2601783002 Cr-Commit-Position: refs/heads/master@{#41958} Committed: https://chromium.googlesource.com/v8/v8/+/d20c23cd13c1affa8e4975dfbf42904282769b31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -52 lines) Patch
M src/i18n.cc View 4 chunks +36 lines, -4 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 13 chunks +29 lines, -9 lines 0 comments Download
D test/intl/bad-target.js View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Dan Ehrenberg
Created Revert of [intl] Remove redundant type checking system
3 years, 12 months ago (2016-12-27 15:04:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601783002/1
3 years, 12 months ago (2016-12-27 15:04:51 UTC) #3
commit-bot: I haz the power
3 years, 12 months ago (2016-12-27 15:31:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d20c23cd13c1affa8e4975dfbf429042827...

Powered by Google App Engine
This is Rietveld 408576698