[intl] Remove redundant type checking system

[intl] Remove redundant type checking system
    
Previously, the Intl implementation tracked types two ways:
 - In the intl_initialized_marker_symbol
 - In various named properties of the intl_impl_object_symbol value
    
As far as I can tell, these will never disagree with each other,
modulo bugs in Intl itself. This patch removes the second type
checking system.
    
BUG=v8:5751
Review-Url: https://codereview.chromium.org/2591203002
Cr-Commit-Position: refs/heads/master@{#41941}
Committed: https://chromium.googlesource.com/v8/v8/+/0d5561b64d34129e6546947255e543c219c61655

[Dan Ehrenberg, 2016-12-21 15:08:29]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 15:08:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 15:23:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 15:23:50]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Dan Ehrenberg, 2016-12-21 16:08:32]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 16:08:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 16:40:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 16:40:15]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-12-21 16:45:34]

Description was changed from

==========
[intl] Remove unreferenced "valid" property from internal object

BUG=v8:5751
==========

to

==========
[intl] Remove redundant type checking system
    
Previously, the Intl implementation tracked types two ways:
 - In the intl_initialized_marker_symbol
 - In various named properties of the intl_impl_object_symbol value
    
As far as I can tell, these will never disagree with each other,
modulo bugs in Intl itself. This patch removes the second type
checking system.
    
BUG=v8:5751
==========

[Dan Ehrenberg, 2016-12-21 16:45:34]

littledan@chromium.org changed reviewers:
+ yangguo@chromium.org

[Dan Ehrenberg, 2016-12-21 16:45:51]

PTAL

[Yang, 2016-12-23 08:55:44]

lgtm

https://codereview.chromium.org/2591203002/diff/20001/test/intl/bad-target.js
File test/intl/bad-target.js (right):

https://codereview.chromium.org/2591203002/diff/20001/test/intl/bad-target.js...
test/intl/bad-target.js:8: assertThrows(() =>
Object.create(Intl.DateTimeFormat.prototype).format(), TypeError);
80 char limit

[Dan Ehrenberg, 2016-12-23 13:50:56]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-12-23 13:50:57]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-12-23 13:50:58]

The CQ bit was unchecked by littledan@chromium.org

[Dan Ehrenberg, 2016-12-23 13:51:04]

The CQ bit was unchecked by littledan@chromium.org

[Dan Ehrenberg, 2016-12-23 13:58:06]

https://codereview.chromium.org/2591203002/diff/20001/test/intl/bad-target.js
File test/intl/bad-target.js (right):

https://codereview.chromium.org/2591203002/diff/20001/test/intl/bad-target.js...
test/intl/bad-target.js:8: assertThrows(() =>
Object.create(Intl.DateTimeFormat.prototype).format(), TypeError);
On 2016/12/23 08:55:44, Yang wrote:
> 80 char limit

Done.

[Dan Ehrenberg, 2016-12-23 13:58:10]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-12-23 13:58:11]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2591203002/#ps40001
(title: "Formatting")

[commit-bot: I haz the power, 2016-12-23 13:58:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 14:23:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482501490698090,
"parent_rev": "fb8b3bcc821cf11c22593d2773c5f06823acd53f", "commit_rev":
"0d5561b64d34129e6546947255e543c219c61655"}

[commit-bot: I haz the power, 2016-12-23 14:23:26]

Description was changed from

==========
[intl] Remove redundant type checking system
    
Previously, the Intl implementation tracked types two ways:
 - In the intl_initialized_marker_symbol
 - In various named properties of the intl_impl_object_symbol value
    
As far as I can tell, these will never disagree with each other,
modulo bugs in Intl itself. This patch removes the second type
checking system.
    
BUG=v8:5751
==========

to

==========
[intl] Remove redundant type checking system
    
Previously, the Intl implementation tracked types two ways:
 - In the intl_initialized_marker_symbol
 - In various named properties of the intl_impl_object_symbol value
    
As far as I can tell, these will never disagree with each other,
modulo bugs in Intl itself. This patch removes the second type
checking system.
    
BUG=v8:5751

Review-Url: https://codereview.chromium.org/2591203002
Cr-Commit-Position: refs/heads/master@{#41941}
Committed:
https://chromium.googlesource.com/v8/v8/+/0d5561b64d34129e6546947255e543c219c...
==========

[commit-bot: I haz the power, 2016-12-23 14:23:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/0d5561b64d34129e6546947255e543c219c...

[Dan Ehrenberg, 2016-12-27 15:04:39]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2601783002/ by littledan@chromium.org.

The reason for reverting is: Issue
https://bugs.chromium.org/p/chromium/issues/detail?id=677055 . I'll send out a
follow-on reland, as it should still be possible to eliminate the redundant type
system..