WindowProxy::initialize should never return null

WindowProxy::initialize should never return null

It's already guaranteed that WindowProxy::initialize never returns null.
This CL just does some refactoring to make the fact clearer.

BUG=

Committed: https://crrev.com/b51d327e851e25c4f85ee59be818dba5db1cae58
Cr-Commit-Position: refs/heads/master@{#440834}

[haraken, 2016-12-27 11:51:39]

haraken@chromium.org changed reviewers:
+ yukishiino@chromium.org

[haraken, 2016-12-27 11:51:40]

PTAL

[haraken, 2016-12-27 15:15:41]

Per an offline discussion with shiino-san, we concluded that this CL may not be
correct until we clean up isContextInitialized/isGlobalInitialized.

However, I begin to think that this CL is correct (i.e., does not change any
existing behavior). See my comments below.

https://codereview.chromium.org/2601773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp (right):

https://codereview.chromium.org/2601773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp:239:
CHECK(isContextInitialized());

isContextInitialized() should return true here because createContext() creates a
ScriptState and a PerContextData.

https://codereview.chromium.org/2601773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp:245:
CHECK(!m_globalProxy.isEmpty());

Unless V8 hits OOM or stack-overflow, m_globalProxy.set should not fail.

https://codereview.chromium.org/2601773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp:248:
setupWindowPrototypeChain();

setupWindowPrototypeChain() never returns false.

[Yuki, 2016-12-28 05:15:17]

LGTM.

[haraken, 2016-12-28 05:15:46]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-12-28 05:15:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 06:54:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482902146787840,
"parent_rev": "e5f04a35afcaa5b1a01f01765b5ea9f5830b83c5", "commit_rev":
"6b85e577db1b9ab7bead55ba37ae433dfa0a5a62"}

[commit-bot: I haz the power, 2016-12-28 06:55:15]

Description was changed from

==========
WindowProxy::initialize should never return null

It's already guaranteed that WindowProxy::initialize never returns null.
This CL just does some refactoring to make the fact clearer.

BUG=
==========

to

==========
WindowProxy::initialize should never return null

It's already guaranteed that WindowProxy::initialize never returns null.
This CL just does some refactoring to make the fact clearer.

BUG=

Review-Url: https://codereview.chromium.org/2601773002
==========

[commit-bot: I haz the power, 2016-12-28 06:55:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-02 15:48:36]

Description was changed from

==========
WindowProxy::initialize should never return null

It's already guaranteed that WindowProxy::initialize never returns null.
This CL just does some refactoring to make the fact clearer.

BUG=

Review-Url: https://codereview.chromium.org/2601773002
==========

to

==========
WindowProxy::initialize should never return null

It's already guaranteed that WindowProxy::initialize never returns null.
This CL just does some refactoring to make the fact clearer.

BUG=

Committed: https://crrev.com/b51d327e851e25c4f85ee59be818dba5db1cae58
Cr-Commit-Position: refs/heads/master@{#440834}
==========

[commit-bot: I haz the power, 2017-01-02 15:48:36]

Patchset 2 (id:??) landed as
https://crrev.com/b51d327e851e25c4f85ee59be818dba5db1cae58
Cr-Commit-Position: refs/heads/master@{#440834}