Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

Issue 2601773002: WindowProxy::initialize should never return null (Closed)
Patch Set: temp Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h
index 7c9fccc0899741a563ed0e464adf67befdcdd46b..c54268d3e793797ac3b5e98791ee3a7a75123031 100644
--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h
+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h
@@ -77,7 +77,7 @@ class WindowProxy final : public GarbageCollectedFinalized<WindowProxy> {
}
bool isGlobalInitialized() { return !m_globalProxy.isEmpty(); }
- bool initializeIfNeeded();
+ void initializeIfNeeded();
void updateDocumentWrapper(v8::Local<v8::Object> wrapper);
void clearForNavigation();
@@ -91,7 +91,7 @@ class WindowProxy final : public GarbageCollectedFinalized<WindowProxy> {
private:
WindowProxy(Frame*, PassRefPtr<DOMWrapperWorld>, v8::Isolate*);
- bool initialize();
+ void initialize();
enum GlobalDetachmentBehavior { DoNotDetachGlobal, DetachGlobal };
void disposeContext(GlobalDetachmentBehavior);
@@ -114,7 +114,7 @@ class WindowProxy final : public GarbageCollectedFinalized<WindowProxy> {
// Associates the window wrapper and its prototype chain with the native
// DOMWindow object. Also does some more Window-specific initialization.
- bool setupWindowPrototypeChain();
+ void setupWindowPrototypeChain();
Member<Frame> m_frame;
v8::Isolate* m_isolate;

Powered by Google App Engine
This is Rietveld 408576698