TaskTraits: Rename WithSyncPrimitives() to WithBaseSyncPrimitives().

TaskTraits: Rename WithSyncPrimitives() to WithBaseSyncPrimitives().

The goal of this change is to make it clear that there is no need
to try to determine whether external APIs use sync primitives when
choosing TaskTraits. WithBaseSyncPrimitives() should only be used
for tasks that use base/ sync primitives.

In a separate CL, we will make sure that there is a DCHECK failure
whenever a task without WithBaseSyncPrimitives() uses a base/
sync primitive.

TBR=sorin@chromium.org,sdefresne@chromium.org,jam@chromium.org
BUG=675660
Committed: https://crrev.com/b7f74ea4888acbcfb6a1e831cfe72e7834e27928
Cr-Commit-Position: refs/heads/master@{#440652}

[fdoray, 2016-12-23 15:28:23]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 15:28:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-12-23 15:29:46]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org

[fdoray, 2016-12-23 15:29:54]

PTAL

[gab, 2016-12-23 15:48:47]

LGTM with comments

https://codereview.chromium.org/2601623002/diff/1/base/task_scheduler/task_tr...
File base/task_scheduler/task_traits.h (right):

https://codereview.chromium.org/2601623002/diff/1/base/task_scheduler/task_tr...
base/task_scheduler/task_traits.h:101: // Tasks with this trait are allowed to
block on these methods:
// Tasks with this trait will pass base::AssertWaitAllowed(), i.e. will be
allowed on the following methods :

https://codereview.chromium.org/2601623002/diff/1/base/task_scheduler/task_tr...
base/task_scheduler/task_traits.h:126: // result in tasks that may block (per
MayBlock()'s definition).
Add one last paragraph :

// In doubt, consult with base/task_scheduler/OWNERS.

[fdoray, 2016-12-23 17:48:16]

https://codereview.chromium.org/2601623002/diff/1/base/task_scheduler/task_tr...
File base/task_scheduler/task_traits.h (right):

https://codereview.chromium.org/2601623002/diff/1/base/task_scheduler/task_tr...
base/task_scheduler/task_traits.h:101: // Tasks with this trait are allowed to
block on these methods:
On 2016/12/23 15:48:47, gab (HOHOHO) wrote:
> // Tasks with this trait will pass base::AssertWaitAllowed(), i.e. will be
> allowed on the following methods :

Done.

https://codereview.chromium.org/2601623002/diff/1/base/task_scheduler/task_tr...
base/task_scheduler/task_traits.h:126: // result in tasks that may block (per
MayBlock()'s definition).
On 2016/12/23 15:48:47, gab (HOHOHO) wrote:
> Add one last paragraph :
> 
> // In doubt, consult with base/task_scheduler/OWNERS.

Done.

[fdoray, 2016-12-23 17:49:29]

Description was changed from

==========
TaskTraits: Rename WithSyncPrimitives() to WithBaseSyncPrimitives().

The goal of this change is to make it clear that there is no need
to try to determine whether external APIs use sync primitives when
choosing TaskTraits. WithBaseSyncPrimitives() should only be used
for tasks that use base/ sync primitives.

In a separate CL, we will make sure that there is a DCHECK failure
whenever a task without WithBaseSyncPrimitives() uses a base/
sync primitive.

BUG=675660
==========

to

==========
TaskTraits: Rename WithSyncPrimitives() to WithBaseSyncPrimitives().

The goal of this change is to make it clear that there is no need
to try to determine whether external APIs use sync primitives when
choosing TaskTraits. WithBaseSyncPrimitives() should only be used
for tasks that use base/ sync primitives.

In a separate CL, we will make sure that there is a DCHECK failure
whenever a task without WithBaseSyncPrimitives() uses a base/
sync primitive.

TBR=sorin@chromium.org,sdefresne@chromium.org,jam@chromium.org
BUG=675660
==========

[fdoray, 2016-12-23 17:49:48]

fdoray@chromium.org changed reviewers:
+ jam@chromium.org, sdefresne@chromium.org, sorin@chromium.org

[fdoray, 2016-12-23 17:49:48]

TBR=sorin@chromium.org,sdefresne@chromium.org,jam@chromium.org for changes to
call sites

[fdoray, 2016-12-23 17:49:54]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-12-23 17:49:55]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2601623002/#ps40001
(title: "CR gab #6")

[commit-bot: I haz the power, 2016-12-23 17:50:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 19:39:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482515394668770,
"parent_rev": "b5b5da8897f3b9bbfeea29c61ddbee8623e91c7b", "commit_rev":
"9f5b279e6c23c48ccbb184a163f54c6e1372e1a4"}

[commit-bot: I haz the power, 2016-12-23 19:39:31]

Description was changed from

==========
TaskTraits: Rename WithSyncPrimitives() to WithBaseSyncPrimitives().

The goal of this change is to make it clear that there is no need
to try to determine whether external APIs use sync primitives when
choosing TaskTraits. WithBaseSyncPrimitives() should only be used
for tasks that use base/ sync primitives.

In a separate CL, we will make sure that there is a DCHECK failure
whenever a task without WithBaseSyncPrimitives() uses a base/
sync primitive.

TBR=sorin@chromium.org,sdefresne@chromium.org,jam@chromium.org
BUG=675660
==========

to

==========
TaskTraits: Rename WithSyncPrimitives() to WithBaseSyncPrimitives().

The goal of this change is to make it clear that there is no need
to try to determine whether external APIs use sync primitives when
choosing TaskTraits. WithBaseSyncPrimitives() should only be used
for tasks that use base/ sync primitives.

In a separate CL, we will make sure that there is a DCHECK failure
whenever a task without WithBaseSyncPrimitives() uses a base/
sync primitive.

TBR=sorin@chromium.org,sdefresne@chromium.org,jam@chromium.org
BUG=675660

Review-Url: https://codereview.chromium.org/2601623002
==========

[commit-bot: I haz the power, 2016-12-23 19:39:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-23 19:41:31]

Description was changed from

==========
TaskTraits: Rename WithSyncPrimitives() to WithBaseSyncPrimitives().

The goal of this change is to make it clear that there is no need
to try to determine whether external APIs use sync primitives when
choosing TaskTraits. WithBaseSyncPrimitives() should only be used
for tasks that use base/ sync primitives.

In a separate CL, we will make sure that there is a DCHECK failure
whenever a task without WithBaseSyncPrimitives() uses a base/
sync primitive.

TBR=sorin@chromium.org,sdefresne@chromium.org,jam@chromium.org
BUG=675660

Review-Url: https://codereview.chromium.org/2601623002
==========

to

==========
TaskTraits: Rename WithSyncPrimitives() to WithBaseSyncPrimitives().

The goal of this change is to make it clear that there is no need
to try to determine whether external APIs use sync primitives when
choosing TaskTraits. WithBaseSyncPrimitives() should only be used
for tasks that use base/ sync primitives.

In a separate CL, we will make sure that there is a DCHECK failure
whenever a task without WithBaseSyncPrimitives() uses a base/
sync primitive.

TBR=sorin@chromium.org,sdefresne@chromium.org,jam@chromium.org
BUG=675660

Committed: https://crrev.com/b7f74ea4888acbcfb6a1e831cfe72e7834e27928
Cr-Commit-Position: refs/heads/master@{#440652}
==========

[commit-bot: I haz the power, 2016-12-23 19:41:32]

Patchset 3 (id:??) landed as
https://crrev.com/b7f74ea4888acbcfb6a1e831cfe72e7834e27928
Cr-Commit-Position: refs/heads/master@{#440652}