base/task_scheduler/task_tracker.cc - Issue 2601623002: TaskTraits: Rename WithSyncPrimitives() to WithBaseSyncPrimitives().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task_scheduler/task_tracker.cc

Issue 2601623002: TaskTraits: Rename WithSyncPrimitives() to WithBaseSyncPrimitives(). (Closed)

Patch Set: CR gab #6 Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/task_scheduler/task_tracker.cc

diff --git a/base/task_scheduler/task_tracker.cc b/base/task_scheduler/task_tracker.cc

index fbeecd3dbe8ec7ca1aadb7a083a21eb5ce5c8ae3..07b0d1216db3ab529be9b6b5b754eb132913ae6d 100644

--- a/base/task_scheduler/task_tracker.cc

+++ b/base/task_scheduler/task_tracker.cc

@@ -226,8 +226,8 @@ bool TaskTracker::RunTask(std::unique_ptr<Task> task,

TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN);

const bool previous_io_allowed =

ThreadRestrictions::SetIOAllowed(task->traits.may_block());

- const bool previous_wait_allowed =

- ThreadRestrictions::SetWaitAllowed(task->traits.with_sync_primitives());

+ const bool previous_wait_allowed = ThreadRestrictions::SetWaitAllowed(

+ task->traits.with_base_sync_primitives());

{

ScopedSetSequenceTokenForCurrentThread