Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Issue 2601553002: Revert of Turn on icu_case_mapping by default (Closed)

Created:
3 years, 12 months ago by adamk
Modified:
3 years, 12 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Turn on icu_case_mapping by default (patchset #4 id:60001 of https://codereview.chromium.org/2588963002/ ) Reason for revert: Causes crashes on Canary: crbug.com/676643 Original issue's description: > Turn on icu_case_mapping by default > > Update string-capitalize expected result because now it > passes all the tests in the file. > Mark fast/js/string-capitalization as failing with no_i18n. > > Relanding after revert because the failure was taken care of > by Adam's CL at https://codereview.chromium.org/2597543002 . > > > BUG=v8:4477, v8:4476 > TEST=test262/{built-ins,intl402}/Strings/*, webkit/fast/js/*, > mjsunit/string-case, intl/general/case* > > Cr-Original-Commit-Position: refs/heads/master@{#41834} > Committed: https://chromium.googlesource.com/v8/v8/+/7c79e23c34ea971947eedc6e42d8a882617c0e47 > Review-Url: https://codereview.chromium.org/2588963002 > Cr-Commit-Position: refs/heads/master@{#41883} > Committed: https://chromium.googlesource.com/v8/v8/+/a42c8c67dece5328896b13d37c5c846a2a0f5b0b TBR=littledan@chromium.org,yangguo@chromium.org,jshin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4477, v8:4476, chromium:676643 Review-Url: https://codereview.chromium.org/2601553002 Cr-Commit-Position: refs/heads/master@{#41928} Committed: https://chromium.googlesource.com/v8/v8/+/207214b60456a843122900fde3c8a3097f63a513

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M src/flag-definitions.h View 2 chunks +12 lines, -5 lines 0 comments Download
M test/webkit/fast/js/string-capitalization-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/webkit/webkit.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
adamk
Created Revert of Turn on icu_case_mapping by default
3 years, 12 months ago (2016-12-22 17:59:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601553002/1
3 years, 12 months ago (2016-12-22 18:00:08 UTC) #4
Dan Ehrenberg
lgtm
3 years, 12 months ago (2016-12-22 18:01:37 UTC) #5
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 18:29:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/207214b60456a843122900fde3c8a3097f6...

Powered by Google App Engine
This is Rietveld 408576698