Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2597543002: Skip regress-trap-allocation-memento in gc_stress (Closed)

Created:
4 years ago by adamk
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Skip regress-trap-allocation-memento in gc_stress This test requires its objects to live in new space, so running it through gc stress runs just makes it susceptible to flakiness, as was recently seen when turning on the --harmony-string-padding flag (which just adds an extra JS file to the bootstrapper sequence). TBR=ishell@chromium.org, jkummerow@chromium.org Review-Url: https://codereview.chromium.org/2597543002 . Cr-Commit-Position: refs/heads/master@{#41876} Committed: https://chromium.googlesource.com/v8/v8/+/75586d3d9ba33ece2f0311911aa0868e4477ef84

Patch Set 1 #

Patch Set 2 : Move test up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
adamk
Committed patchset #2 (id:20001) manually as 75586d3d9ba33ece2f0311911aa0868e4477ef84 (presubmit successful).
4 years ago (2016-12-20 23:09:25 UTC) #3
Igor Sheludko
lgtm
4 years ago (2016-12-20 23:11:36 UTC) #4
jungshik at Google
4 years ago (2016-12-21 06:11:47 UTC) #5
Message was sent while issue was closed.
On 2016/12/20 23:09:25, adamk wrote:
> Committed patchset #2 (id:20001) manually as
> 75586d3d9ba33ece2f0311911aa0868e4477ef84 (presubmit successful).

Thanks Adam ! The same thing happened when I moved --icu_case_mapping to
Harmnoy_shipping. (it also adds an extra JS file to bootstrapper sequence).

Powered by Google App Engine
This is Rietveld 408576698