Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2601463002: Revert of [turbofan] reenable escape analysis to further investigate crashes (Closed)

Created:
4 years ago by Tobias Tebbi
Modified:
4 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] reenable escape analysis to further investigate crashes (patchset #1 id:1 of https://codereview.chromium.org/2589163002/ ) Reason for revert: still crashing with the known issues Original issue's description: > [turbofan] reenable escape analysis to further investigate crashes > > R=jarin@chromium.org > > BUG=chromium:669242 > > Review-Url: https://codereview.chromium.org/2589163002 > Cr-Commit-Position: refs/heads/master@{#41857} > Committed: https://chromium.googlesource.com/v8/v8/+/fd4812323f8c90662be1d0961fbeaabe52565478 TBR=jarin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:669242 Review-Url: https://codereview.chromium.org/2601463002 Cr-Commit-Position: refs/heads/master@{#41918} Committed: https://chromium.googlesource.com/v8/v8/+/8dad4feec9e45c1ba910808a388274f375584b5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M src/compiler/escape-analysis.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Tobias Tebbi
Created Revert of [turbofan] reenable escape analysis to further investigate crashes
4 years ago (2016-12-22 10:16:53 UTC) #1
Tobias Tebbi
4 years ago (2016-12-22 10:17:21 UTC) #2
Jarin
lgtm.
4 years ago (2016-12-22 10:24:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601463002/1
4 years ago (2016-12-22 10:27:35 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-22 10:56:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8dad4feec9e45c1ba910808a388274f3755...

Powered by Google App Engine
This is Rietveld 408576698