Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 2589163002: [turbofan] reenable escape analysis to further investigate crashes (Closed)

Created:
4 years ago by Tobias Tebbi
Modified:
4 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] reenable escape analysis to further investigate crashes R=jarin@chromium.org BUG=chromium:669242 Review-Url: https://codereview.chromium.org/2589163002 Cr-Commit-Position: refs/heads/master@{#41857} Committed: https://chromium.googlesource.com/v8/v8/+/fd4812323f8c90662be1d0961fbeaabe52565478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/compiler/escape-analysis.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Tobias Tebbi
4 years ago (2016-12-20 10:53:06 UTC) #1
Jarin
lgtm
4 years ago (2016-12-20 11:26:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589163002/1
4 years ago (2016-12-20 12:04:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/fd4812323f8c90662be1d0961fbeaabe52565478
4 years ago (2016-12-20 12:33:24 UTC) #7
Tobias Tebbi
4 years ago (2016-12-22 10:16:52 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2601463002/ by tebbi@chromium.org.

The reason for reverting is: still crashing with the known issues.

Powered by Google App Engine
This is Rietveld 408576698