Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2601343002: The great shader refactor: Merge fragment uniforms (Closed)

Created:
3 years, 11 months ago by ccameron
Modified:
3 years, 11 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The great shader refactor: Merge fragment uniforms Move uniform management to the base fragment program, rather than repeating them in every sub-class. BUG=667966 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/f9fa543ecdbcf8a51ad0992d943ca77e20d7991c Cr-Commit-Position: refs/heads/master@{#441249}

Patch Set 1 #

Patch Set 2 : Clean up rebase #

Patch Set 3 : The great shader refactor: Merge fragment uniforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -682 lines) Patch
M cc/output/shader.h View 1 8 chunks +107 lines, -220 lines 0 comments Download
M cc/output/shader.cc View 1 17 chunks +87 lines, -462 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (17 generated)
enne (OOO)
lgtm
3 years, 11 months ago (2017-01-03 22:27:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601343002/40001
3 years, 11 months ago (2017-01-03 22:48:43 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2017-01-03 23:25:22 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 23:28:14 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f9fa543ecdbcf8a51ad0992d943ca77e20d7991c
Cr-Commit-Position: refs/heads/master@{#441249}

Powered by Google App Engine
This is Rietveld 408576698