Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2405)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

Issue 2601273003: Send users to Physical WebUI instead of Activity (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
index 19737bac5e43b554c2301cd12e980d39ad24f8f9..5da90fcd773595b342116c2ce05ba4b74bd3c617 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
@@ -5,7 +5,6 @@
package org.chromium.chrome.browser.physicalweb;
import android.app.Activity;
-import android.content.Intent;
import android.content.res.Resources;
import android.os.Build;
import android.text.Html;
@@ -16,9 +15,9 @@ import android.widget.Button;
import android.widget.TextView;
import org.chromium.base.ApiCompatibilityUtils;
-import org.chromium.base.ContextUtils;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.BasicNativePage;
+import org.chromium.chrome.browser.IntentHandler;
import org.chromium.chrome.browser.UrlConstants;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.components.location.LocationUtils;
@@ -64,7 +63,9 @@ public class PhysicalWebDiagnosticsPage extends BasicNativePage {
mLaunchButton.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
- activity.startActivity(createListUrlsIntent());
+ PhysicalWebUma.onActivityReferral(ListUrlsActivity.DIAGNOSTICS_REFERER);
+ IntentHandler.startChromeLauncherActivityForTrustedIntent(
+ PhysicalWeb.createListUrlsIntent());
}
});
@@ -218,11 +219,6 @@ public class PhysicalWebDiagnosticsPage extends BasicNativePage {
return (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT);
}
- private static Intent createListUrlsIntent() {
- return new Intent(ContextUtils.getApplicationContext(), ListUrlsActivity.class)
- .putExtra(ListUrlsActivity.REFERER_KEY, ListUrlsActivity.DIAGNOSTICS_REFERER);
- }
-
private static String colorToHexValue(int color) {
return "#" + Integer.toHexString(color & 0x00ffffff);
}

Powered by Google App Engine
This is Rietveld 408576698