Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2601203002: Fix crash during CertificateReportingService shutdown (Closed)

Created:
3 years, 11 months ago by meacer
Modified:
3 years, 11 months ago
Reviewers:
Jialiu Lin
CC:
chromium-reviews, grt+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash during CertificateReportingService shutdown CertificateReportingService::ShutDown posts a task to the IO thread to delete reporter_. If the service's destructor is already run, this will cause a crash during shutdown. Instead, delete reporter_ using a static method and without referencing CertificateReportingService's |this|. BUG=677329 Committed: https://crrev.com/9fd701ecdc48f80651ff8a6824f55875730ea1b3 Cr-Commit-Position: refs/heads/master@{#440933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -31 lines) Patch
M chrome/browser/safe_browsing/certificate_reporting_service.h View 5 chunks +7 lines, -14 lines 0 comments Download
M chrome/browser/safe_browsing/certificate_reporting_service.cc View 8 chunks +21 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
meacer
jialiul: Can you please take a look? Thanks!
3 years, 11 months ago (2016-12-29 00:47:54 UTC) #4
Jialiu Lin
lgtm
3 years, 11 months ago (2016-12-29 01:57:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601203002/1
3 years, 11 months ago (2016-12-29 03:08:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 03:12:25 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:51:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fd701ecdc48f80651ff8a6824f55875730ea1b3
Cr-Commit-Position: refs/heads/master@{#440933}

Powered by Google App Engine
This is Rietveld 408576698