Fix crash during CertificateReportingService shutdown

chrome/browser/safe_browsing/certificate_reporting_service.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_CERTIFICATE_REPORTING_SERVICE_H_
 #define CHROME_BROWSER_SAFE_BROWSING_CERTIFICATE_REPORTING_SERVICE_H_
 
 #include <map>
 #include <memory>
 #include <string>
@@ skipping 86 matching lines @@
 
     DISALLOW_COPY_AND_ASSIGN(BoundedReportList);
   };
 
   // Class that handles report uploads and implements the upload retry logic.
   class Reporter {
    public:
     Reporter(
         std::unique_ptr<certificate_reporting::ErrorReporter> error_reporter_,
         std::unique_ptr<BoundedReportList> retry_list,
-        base::Clock* clock,
+        base::Clock* const clock,
         base::TimeDelta report_ttl,
         bool retries_enabled);
     ~Reporter();
 
     // Sends a report. If the send fails, the report will be added to the retry
     // list.
     void Send(const std::string& serialized_report);
 
     // Sends all pending reports. Skips reports older than the |report_ttl|
     // provided in the constructor. Failed reports will be added to the retry
     // list.
     void SendPending();
 
     // Getter and setters for testing:
     size_t inflight_report_count_for_testing() const;
     BoundedReportList* GetQueueForTesting() const;
 
    private:
     void SendInternal(const Report& report);
     void ErrorCallback(int report_id, const GURL& url, int error);
     void SuccessCallback(int report_id);
 
     std::unique_ptr<certificate_reporting::ErrorReporter> error_reporter_;
     std::unique_ptr<BoundedReportList> retry_list_;
-    base::Clock* clock_;
+    base::Clock* const clock_;
     // Maximum age of a queued report. Reports older than this are discarded in
     // the next SendPending() call.
     const base::TimeDelta report_ttl_;
     const bool retries_enabled_;
     // Current report id, starting from zero and monotonically incrementing.
     int current_report_id_;
 
     std::map<int, Report> inflight_reports_;
 
     base::WeakPtrFactory<Reporter> weak_factory_;
@@ skipping 26 matching lines @@
   // Enables or disables reporting. When disabled, pending report queue is
   // cleared and incoming reports are ignored. Reporting is enabled by default
   // once the service is initialized.
   void SetEnabled(bool enabled);
 
   // Getters for testing.
   Reporter* GetReporterForTesting() const;
   static GURL GetReportingURLForTesting();
 
  private:
-  void Reset();
-
   void InitializeOnIOThread(
       bool enabled,
       scoped_refptr<net::URLRequestContextGetter> url_request_context_getter,
       size_t max_queued_report_count,
       base::TimeDelta max_report_age,
-      base::Clock* clock,
+      base::Clock* const clock,
       uint8_t* server_public_key,
       uint32_t server_public_key_version);
 
   // Resets the reporter on the IO thread. Changes in SafeBrowsing or extended
   // reporting enabled states cause the reporter to be reset.
   // If |enabled| is false or |url_request_context_getter| is null, report is
   // set to null, effectively cancelling all in flight uploads and clearing the
   // pending reports queue.
   void ResetOnIOThread(bool enabled,
                        net::URLRequestContext* url_request_context,
                        size_t max_queued_report_count,
                        base::TimeDelta max_report_age,
-                       base::Clock* clock,
+                       base::Clock* const clock,
                        uint8_t* server_public_key,
                        uint32_t server_public_key_version);
 
   void OnPreferenceChanged();
 
   const PrefService& pref_service_;
-
-  // If true, reporting is enabled. When SafeBrowsing preferences change, this
-  // might be set to false.
-  bool enabled_;
-
   net::URLRequestContext* url_request_context_;
   std::unique_ptr<Reporter> reporter_;
 
   // Subscription for url request context shutdowns. When this subscription is
   // notified, it means SafeBrowsingService is shutting down, and this service
   // must also shut down.
   std::unique_ptr<base::CallbackList<void(void)>::Subscription>
       safe_browsing_service_shutdown_subscription_;
 
   // Subscription for state changes. When this subscription is notified, it
   // means SafeBrowsingService is enabled/disabled or one of the preferences
   // related to it is changed.
   std::unique_ptr<base::CallbackList<void(void)>::Subscription>
       safe_browsing_state_subscription_;
 
   // Maximum number of reports to be queued for retry.
-  size_t max_queued_report_count_;
+  const size_t max_queued_report_count_;
 
   // Maximum age of the reports to be queued for retry, from the time the
   // certificate error was first encountered by the user. Any report older than
   // this age is ignored and is not re-uploaded.
-  base::TimeDelta max_report_age_;
+  const base::TimeDelta max_report_age_;
 
-  base::Clock* clock_;
+  base::Clock* const clock_;
 
   // Encryption parameters.
   uint8_t* server_public_key_;
   uint32_t server_public_key_version_;
 
   DISALLOW_COPY_AND_ASSIGN(CertificateReportingService);
 };
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_CERTIFICATE_REPORTING_SERVICE_H_