Blacklisting of method names coming from std library.

Blacklisting of method names coming from std library.

BUG=672902
Committed: https://crrev.com/fa323b77ef5fbe07d35990c36eb3ad84eece2d5f
Cr-Commit-Position: refs/heads/master@{#440879}

[Łukasz Anforowicz, 2016-12-28 18:02:00]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2016-12-28 18:02:01]

Daniel, can you PTAL?

[dcheng, 2016-12-28 18:19:09]

https://codereview.chromium.org/2601063002/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2601063002/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:237: "back",
"empty", "erase", "front",
What about insert?

[Łukasz Anforowicz, 2016-12-28 18:27:17]

https://codereview.chromium.org/2601063002/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2601063002/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:237: "back",
"empty", "erase", "front",
On 2016/12/28 18:19:09, dcheng wrote:
> What about insert?

Oops.  "insert" is mentioned explicitly in
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/UjgsNYcB3Qc - I
don't know how I missed this.

Done.

[Łukasz Anforowicz, 2016-12-28 18:34:46]

+pilgrim@ to CC

[dcheng, 2016-12-28 18:37:18]

lgtm

[Łukasz Anforowicz, 2016-12-28 19:32:02]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-12-28 19:32:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 19:40:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482953522371300,
"parent_rev": "205125fb998f6ef68de60365e971082f85fb2d48", "commit_rev":
"322073df1f6583f98ada23e6a6d942050743fee1"}

[commit-bot: I haz the power, 2016-12-28 19:41:04]

Description was changed from

==========
Blacklisting of method names coming from std library.

BUG=672902
==========

to

==========
Blacklisting of method names coming from std library.

BUG=672902

Review-Url: https://codereview.chromium.org/2601063002
==========

[commit-bot: I haz the power, 2016-12-28 19:41:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-02 15:49:53]

Description was changed from

==========
Blacklisting of method names coming from std library.

BUG=672902

Review-Url: https://codereview.chromium.org/2601063002
==========

to

==========
Blacklisting of method names coming from std library.

BUG=672902

Committed: https://crrev.com/fa323b77ef5fbe07d35990c36eb3ad84eece2d5f
Cr-Commit-Position: refs/heads/master@{#440879}
==========

[commit-bot: I haz the power, 2017-01-02 15:49:54]

Patchset 2 (id:??) landed as
https://crrev.com/fa323b77ef5fbe07d35990c36eb3ad84eece2d5f
Cr-Commit-Position: refs/heads/master@{#440879}