Blacklisting of method names coming from std library.

tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Changes Blink-style names to Chrome-style names. Currently transforms:
 //   fields:
 //     int m_operationCount => int operation_count_
 //   variables (including parameters):
 //     int mySuperVariable => int my_super_variable
 //   constants:
@@ skipping 190 matching lines @@
     return true;
   for (auto it = decl.begin_overridden_methods();
        it != decl.end_overridden_methods(); ++it) {
     if (IsMethodOverrideOf(**it, class_name))
       return true;
   }
   return false;
 }
 
 bool IsBlacklistedFunctionName(llvm::StringRef name) {
+  // https://crbug.com/672902: Method names with an underscore are typically
+  // mimicked after std library / are typically not originating from Blink.
+  // Do not rewrite such names (like push_back, emplace_back, etc.).
+  if (name.find('_') != llvm::StringRef::npos)
+    return true;
+
   // https://crbug.com/677166: Have to avoid renaming |hash| -> |Hash| to avoid
   // colliding with a struct already named |Hash|.
   return name == "hash";
 }
 
 bool IsBlacklistedFreeFunctionName(llvm::StringRef name) {
   // swap() functions should match the signature of std::swap for ADL tricks.
   return name == "swap";
 }
 
 bool IsBlacklistedInstanceMethodName(llvm::StringRef name) {
   static const char* kBlacklistedNames[] = {
       // We should avoid renaming the method names listed below, because
       // 1. They are used in templated code (e.g. in <algorithms>)
       // 2. They (begin+end) are used in range-based for syntax sugar
       //    - for (auto x : foo) { ... }  // <- foo.begin() will be called.
       "begin", "end", "rbegin", "rend", "lock", "unlock", "try_lock",
+
+      // https://crbug.com/672902: Should not rewrite names that mimick methods
+      // from std library.
+      "back", "empty", "erase", "front", "insert",
   };
   for (const auto& b : kBlacklistedNames) {
     if (name == b)
       return true;
   }
   return false;
 }
 
 bool IsBlacklistedFunction(const clang::FunctionDecl& decl) {
   clang::StringRef name = decl.getName();
@@ skipping 1140 matching lines @@
   for (const auto& r : replacements) {
     std::string replacement_text = r.getReplacementText().str();
     std::replace(replacement_text.begin(), replacement_text.end(), '\n', '\0');
     llvm::outs() << "r:::" << r.getFilePath() << ":::" << r.getOffset()
                  << ":::" << r.getLength() << ":::" << replacement_text << "\n";
   }
   llvm::outs() << "==== END EDITS ====\n";
 
   return 0;
 }