Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2601043002: Re-enables the readability/fn_size presubmit. (Closed)

Created:
3 years, 12 months ago by epertoso
Modified:
3 years, 11 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-enables the readability/fn_size presubmit. BUG= Review-Url: https://codereview.chromium.org/2601043002 Cr-Commit-Position: refs/heads/master@{#41969} Committed: https://chromium.googlesource.com/v8/v8/+/ee1b69a480d734c15d98fccc024385e43bc65cbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/presubmit.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
epertoso
3 years, 12 months ago (2016-12-28 10:03:19 UTC) #5
mvstanton
lgtm
3 years, 12 months ago (2016-12-28 10:04:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601043002/1
3 years, 11 months ago (2016-12-28 10:14:03 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2016-12-28 11:42:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ee1b69a480d734c15d98fccc024385e43bc...

Powered by Google App Engine
This is Rietveld 408576698