tools/presubmit.py - Issue 2601043002: Re-enables the readability/fn_size presubmit. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(120)

My Issues | Starred Open | Closed | All

Unified Diff: tools/presubmit.py

Issue 2601043002: Re-enables the readability/fn_size presubmit. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/presubmit.py

diff --git a/tools/presubmit.py b/tools/presubmit.py

index 8cd35d09d77ad961b5e6d564bde14ff4c12a1ece..c75b78b54469b7ee9cc0e61a07fe3b6375db5521 100755

--- a/tools/presubmit.py

+++ b/tools/presubmit.py

@@ -55,7 +55,6 @@ from testrunner.local import utils

# build/include_what_you_use: Started giving false positives for variables

# named "string" and "map" assuming that you needed to include STL headers.

# TODO(bmeurer): Fix and re-enable readability/check

-# TODO(epertoso): Maybe re-enable readability/fn_size after

# http://crrev.com/2199323003 relands.

LINT_RULES = """

@@ -63,7 +62,6 @@ LINT_RULES = """

-build/include_what_you_use

-build/namespaces

-readability/check

--readability/fn_size

+readability/streams

-runtime/references

""".split()

« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698