Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2600773002: Revert of Disable the CompilerDispatcher if we don't have idle time (Closed)

Created:
3 years, 12 months ago by Michael Achenbach
Modified:
3 years, 12 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Disable the CompilerDispatcher if we don't have idle time (patchset #1 id:1 of https://codereview.chromium.org/2600743002/ ) Reason for revert: [Sheriff] Speculative revert since we got persistent timeouts on win32 debug: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/6417 Please reland if it doesn't help. Original issue's description: > Disable the CompilerDispatcher if we don't have idle time > > Since we can't do all steps on background threads, we need idle time to > work > > BUG=v8:5215 > R=danno@chromium.org > > Review-Url: https://codereview.chromium.org/2600743002 > Cr-Commit-Position: refs/heads/master@{#41944} > Committed: https://chromium.googlesource.com/v8/v8/+/a0d9eb346bba90aa0b32a2d3184cbbfd6adb243e TBR=danno@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5215 Review-Url: https://codereview.chromium.org/2600773002 Cr-Commit-Position: refs/heads/master@{#41948} Committed: https://chromium.googlesource.com/v8/v8/+/26325f0c8d2fc3149457f63be88dd15238e6496d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -37 lines) Patch
M src/compiler-dispatcher/compiler-dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher.cc View 3 chunks +1 line, -8 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +0 lines, -4 lines 0 comments Download
M test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc View 1 chunk +1 line, -24 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of Disable the CompilerDispatcher if we don't have idle time
3 years, 12 months ago (2016-12-23 19:03:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600773002/1
3 years, 12 months ago (2016-12-23 19:03:42 UTC) #3
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 19:03:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/26325f0c8d2fc3149457f63be88dd15238e...

Powered by Google App Engine
This is Rietveld 408576698