Convert budget LayoutTests to use promise_test.

Convert budget LayoutTests to use promise_test.

The infrastructure of async_test LayoutTests was changed recently, and
one effect is that an assert inside an event listener will cause the
test to time out instead of returning the error. This makes the test
much more difficult to debug failures. Additionally, promise_test is just
nicer when it's easy to return a promise.

This CL updates the existing budget tests which run in service workers to
use promise_test. It also cleans up a bit of style.

BUG=617971
Review-Url: https://codereview.chromium.org/2600733002
Cr-Commit-Position: refs/heads/master@{#441931}
Committed: https://chromium.googlesource.com/chromium/src/+/66cd34190886e221b7d79beac0b19cf6b2ebf633

[harkness, 2016-12-23 13:33:19]

harkness@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2017-01-04 18:18:11]

lgtm w/ nits

https://codereview.chromium.org/2600733002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html
(right):

https://codereview.chromium.org/2600733002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html:22:
.then(function(workerInfo) {
nit: I'd move the .then() a level up, i.e.

return budgetServiceMock.then(mock => {
  return myOtherPromiseMethod();
}).then(workerInfo => {
  ...
});

That avoids nesting, and splits the test in clear sections.

https://codereview.chromium.org/2600733002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html:38:
.catch(unreached_rejection(test));
You should drop these - a rejection in a promise_test is seen as a failure. (Now
the returned promise will actually *resolve*.)

[harkness, 2017-01-06 13:37:10]

https://codereview.chromium.org/2600733002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html
(right):

https://codereview.chromium.org/2600733002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html:22:
.then(function(workerInfo) {
On 2017/01/04 18:18:11, Peter Beverloo wrote:
> nit: I'd move the .then() a level up, i.e.
> 
> return budgetServiceMock.then(mock => {
>   return myOtherPromiseMethod();
> }).then(workerInfo => {
>   ...
> });
> 
> That avoids nesting, and splits the test in clear sections.

Done.

https://codereview.chromium.org/2600733002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html:38:
.catch(unreached_rejection(test));
On 2017/01/04 18:18:11, Peter Beverloo wrote:
> You should drop these - a rejection in a promise_test is seen as a failure.
(Now
> the returned promise will actually *resolve*.)

Done.

[harkness, 2017-01-06 13:37:20]

The CQ bit was checked by harkness@chromium.org

[harkness, 2017-01-06 13:37:21]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2600733002/#ps20001
(title: "Changed then scoping and removed unnecessary rejection.")

[commit-bot: I haz the power, 2017-01-06 13:37:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 14:57:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483709840605580,
"parent_rev": "6edea0df16b61798c29e6f44766155bedfe66ab0", "commit_rev":
"66cd34190886e221b7d79beac0b19cf6b2ebf633"}

[commit-bot: I haz the power, 2017-01-06 14:58:18]

Description was changed from

==========
Convert budget LayoutTests to use promise_test.

The infrastructure of async_test LayoutTests was changed recently, and
one effect is that an assert inside an event listener will cause the
test to time out instead of returning the error. This makes the test
much more difficult to debug failures. Additionally, promise_test is just
nicer when it's easy to return a promise.

This CL updates the existing budget tests which run in service workers to
use promise_test. It also cleans up a bit of style.

BUG=617971
==========

to

==========
Convert budget LayoutTests to use promise_test.

The infrastructure of async_test LayoutTests was changed recently, and
one effect is that an assert inside an event listener will cause the
test to time out instead of returning the error. This makes the test
much more difficult to debug failures. Additionally, promise_test is just
nicer when it's easy to return a promise.

This CL updates the existing budget tests which run in service workers to
use promise_test. It also cleans up a bit of style.

BUG=617971

Review-Url: https://codereview.chromium.org/2600733002
Cr-Commit-Position: refs/heads/master@{#441931}
Committed:
https://chromium.googlesource.com/chromium/src/+/66cd34190886e221b7d79beac0b1...
==========

[commit-bot: I haz the power, 2017-01-06 14:58:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/66cd34190886e221b7d79beac0b1...