Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html

Issue 2600733002: Convert budget LayoutTests to use promise_test. (Closed)
Patch Set: Changed then scoping and removed unnecessary rejection. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/budget/get-cost-fails-in-service-worker.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html b/third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html
index 999c7c1e864e55c18f1d22a2f9b43a2bf1e62b1f..71de5da525498456a2f2e23877f503e9db8ca367 100644
--- a/third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html
+++ b/third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html
@@ -11,32 +11,30 @@
</head>
<body>
<script>
- async_test(function(test) {
- var script = 'resources/instrumentation-service-worker.js';
- var scope = 'resources/scope/' + location.pathname;
- var port;
+ promise_test(function(test) {
+ const script = 'resources/instrumentation-service-worker.js';
+ const scope = 'resources/scope/' + location.pathname;
+ let port;
- budgetServiceMock.then(mock => {
+ return budgetServiceMock.then(mock => {
mock.addBudget(TEST_BUDGET_TIME, TEST_BUDGET_AT);
- getActiveServiceWorkerWithMessagePort(test, script, scope)
- .then(function(workerInfo) {
- port = workerInfo.port;
- port.postMessage({command: 'getBudget'});
+ return getActiveServiceWorkerWithMessagePort(test, script, scope);
+ }).then(function(workerInfo) {
+ port = workerInfo.port;
- port.addEventListener('message', function(event) {
- if (typeof event.data != 'object' || !event.data.command)
- assert_unreached('Invalid message from the service worker');
+ port.addEventListener('message', function(event) {
+ if (typeof event.data != 'object' || !event.data.command)
+ assert_unreached('Invalid message from the service worker');
- assert_equals(event.data.command, 'getBudget');
- assert_true(event.data.success,
- 'getBudget should succeed. Error message: ' + event.data.errorMessage);
- assert_equals(event.data.budgetAt, TEST_BUDGET_AT);
- assert_equals(event.data.time, TEST_BUDGET_TIME);
- test.done();
- });
- })
- .catch(unreached_rejection(test));
- });
+ assert_equals(event.data.command, 'getBudget');
+ assert_true(event.data.success,
+ 'getBudget should succeed. Error message: ' + event.data.errorMessage);
+ assert_equals(event.data.budgetAt, TEST_BUDGET_AT);
+ assert_equals(event.data.time, TEST_BUDGET_TIME);
+ });
+
+ return sendCommand(port, { command: 'getBudget' });
+ });
}, 'getBudget should succeed from Service Worker');
</script>
</body>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/budget/get-cost-fails-in-service-worker.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698