Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(71)

Issue 2600453006: Fix native_client/PRESUBMIT.py . (Closed)

Created:
2 years, 6 months ago by Jim Stichnoth
Modified:
2 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Fix native_client/PRESUBMIT.py . A depot_tools change - https://codereview.chromium.org/2394043002 - requires a corresponding change in our PRESUBMIT.py . Doing a "git cl try" is enough to trigger the problem. BUG= none NOTRY=true Review-Url: https://codereview.chromium.org/2600453006 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/25f277533941cf6c733ff70ae3e7713423ba60f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Jim Stichnoth
2 years, 6 months ago (2016-12-24 14:23:56 UTC) #4
Derek Schuff
lgtm
2 years, 5 months ago (2017-01-03 16:45:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600453006/1
2 years, 5 months ago (2017-01-03 18:42:36 UTC) #8
commit-bot: I haz the power
2 years, 5 months ago (2017-01-03 18:44:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/25f277533...

Powered by Google App Engine
This is Rietveld 408576698