Remove SVN support from PRESUBMIT

Remove SVN support from PRESUBMIT

R=maruel@chromium.org
BUG=475320
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/0b65e732b44fbbbd4e40062b4581c47a95afb36d

[M-A Ruel, 2016-10-05 21:25:33]

https://codereview.chromium.org/2394043002/diff/1/presubmit_support.py
File presubmit_support.py (right):

https://codereview.chromium.org/2394043002/diff/1/presubmit_support.py#newcod...
presubmit_support.py:437: def AffectedTestableFiles(self, include_deletes=None):
This increases the odd of this CL blowing up. Are you sure you want to do this
refactoring simultaneously?

[agable, 2016-10-05 22:51:01]

https://codereview.chromium.org/2394043002/diff/1/presubmit_support.py
File presubmit_support.py (right):

https://codereview.chromium.org/2394043002/diff/1/presubmit_support.py#newcod...
presubmit_support.py:437: def AffectedTestableFiles(self, include_deletes=None):
On 2016/10/05 at 21:25:33, M-A Ruel wrote:
> This increases the odd of this CL blowing up. Are you sure you want to do this
refactoring simultaneously?

Sigh, you're right, it would kill a bunch of PRESUBMIT files. But instead of
undoing it, I've added aliases.

[M-A Ruel, 2016-10-05 23:22:54]

lgtm

[agable, 2016-11-22 17:21:59]

The CQ bit was checked by agable@chromium.org

[agable, 2016-11-22 17:22:00]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/2394043002/#ps60001
(title: "Updated patchset dependency")

[commit-bot: I haz the power, 2016-11-22 17:22:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 17:25:46]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479835319844750,
"parent_rev": "0bfa9ad781d20a6514aa07c0bc711605b10d99fa", "commit_rev":
"0b65e732b44fbbbd4e40062b4581c47a95afb36d"}

[commit-bot: I haz the power, 2016-11-22 17:25:49]

Description was changed from

==========
Remove SVN support from PRESUBMIT

R=maruel@chromium.org
BUG=475320
==========

to

==========
Remove SVN support from PRESUBMIT

R=maruel@chromium.org
BUG=475320

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/0b65e732b44fbb...
==========

[commit-bot: I haz the power, 2016-11-22 17:25:50]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/0b65e732b44fbb...

[Dan Beam, 2016-11-29 19:13:44]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-11-29 19:13:45]

https://codereview.chromium.org/2394043002/diff/60001/presubmit_support.py
File presubmit_support.py (left):

https://codereview.chromium.org/2394043002/diff/60001/presubmit_support.py#ol...
presubmit_support.py:441: def AffectedFiles(self, include_dirs=False,
include_deletes=True,
can you grep for keywords when you remove them next time?

this broke third_party/polymer/v1_0/PRESUBMIT.py as well as (likely)
native_client/PRESUBMIT.py

https://cs.chromium.org/search/?q=include_dirs%3D+affectedfiles&sq=package:ch...

[Dan Beam, 2016-11-29 19:16:30]

https://codereview.chromium.org/2394043002/diff/60001/presubmit_support.py
File presubmit_support.py (left):

https://codereview.chromium.org/2394043002/diff/60001/presubmit_support.py#ol...
presubmit_support.py:441: def AffectedFiles(self, include_dirs=False,
include_deletes=True,
On 2016/11/29 19:13:45, Dan Beam wrote:
> can you grep for keywords when you remove them next time?
> 
> this broke third_party/polymer/v1_0/PRESUBMIT.py as well as (likely)
> native_client/PRESUBMIT.py
> 
>
https://cs.chromium.org/search/?q=include_dirs%3D+affectedfiles&sq=package:ch...

"this broke" -> removing include_dirs=