Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2600453003:
Do not apply ink-skipping to line-through text decoration (Closed)
DescriptionDo not apply ink-skipping to line-through text decoration
Discussion resolved in WG issue tracker:
https://github.com/w3c/csswg-drafts/issues/711
BUG=670599
R=kojii
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2600453003
Cr-Commit-Position: refs/heads/master@{#444343}
Committed: https://chromium.googlesource.com/chromium/src/+/9a91abd16665860a7ab53a307b8e87c5783fbc6c
Patch Set 1 #Patch Set 2 : Adding rebaseline #
Messages
Total messages: 29 (20 generated)
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Description was changed from ========== Do not apply ink-skipping to line-through text decoration Discussion resolved in WG issue tracker: https://github.com/w3c/csswg-drafts/issues/711 BUG=670599 R=kojii ========== to ========== Do not apply ink-skipping to line-through text decoration Discussion resolved in WG issue tracker: https://github.com/w3c/csswg-drafts/issues/711 BUG=670599 R=kojii CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
drott@chromium.org changed reviewers: + eae@chromium.org
drott@chromium.org changed reviewers: + eae@chromium.org
I am running webkit-patch rebaseline-cl to fetch the baselines and will updated the CL with those.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
lgtm, thank you!
LGTM
The CQ bit was checked by drott@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by drott@chromium.org
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Adding rebaseline
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by drott@chromium.org
The CQ bit was checked by drott@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kojii@chromium.org, eae@chromium.org Link to the patchset: https://codereview.chromium.org/2600453003/#ps20001 (title: "Adding rebaseline")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484740629745250,
"parent_rev": "cd3f19adeb8b19062badb591ff33b770dd0eb21f", "commit_rev":
"9a91abd16665860a7ab53a307b8e87c5783fbc6c"}
Message was sent while issue was closed.
Description was changed from ========== Do not apply ink-skipping to line-through text decoration Discussion resolved in WG issue tracker: https://github.com/w3c/csswg-drafts/issues/711 BUG=670599 R=kojii CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Do not apply ink-skipping to line-through text decoration Discussion resolved in WG issue tracker: https://github.com/w3c/csswg-drafts/issues/711 BUG=670599 R=kojii CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2600453003 Cr-Commit-Position: refs/heads/master@{#444343} Committed: https://chromium.googlesource.com/chromium/src/+/9a91abd16665860a7ab53a307b8e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/9a91abd16665860a7ab53a307b8e... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
