Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

Issue 2600453003: Do not apply ink-skipping to line-through text decoration (Closed)
Patch Set: Adding rebaseline Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip-expected.png ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
index c963f48248f2a75015efbe55a75b93b3c3e67c93..eb5a60a4f93f66709a82faeb434a34e6a39f251c 100644
--- a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
@@ -1134,13 +1134,8 @@ void InlineTextBoxPainter::paintDecorations(
context, FloatPoint(localOrigin) + FloatPoint(0, lineThroughOffset),
width.toFloat(), decoration, textDecorationThickness, doubleOffset, 0,
antialiasDecoration);
- if (skipIntercepts) {
- textPainter.clipDecorationsStripe(
- -baseline + decorationPainter.decorationBounds().y() -
- FloatPoint(localOrigin).y(),
- decorationPainter.decorationBounds().height(),
- textDecorationThickness);
- }
+ // No skip: ink for line-through,
+ // compare https://github.com/w3c/csswg-drafts/issues/711
decorationPainter.paint();
}
}
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip-expected.png ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698