Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 26004003: Fix shared_library build after r17107 (Closed)

Created:
7 years, 2 months ago by Jakob Kummerow
Modified:
7 years, 2 months ago
Reviewers:
rmcilroy
CC:
v8-dev
Visibility:
Public.

Description

Fix shared_library build after r17107 R=rmcilroy@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17109

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/platform/elapsed-timer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/platform/mutex.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/platform/semaphore.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/platform/time.h View 1 chunk +1 line, -1 line 0 comments Download
M src/unicode.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 3 chunks +5 lines, -5 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
PTAL.
7 years, 2 months ago (2013-10-04 14:10:44 UTC) #1
rmcilroy
Thanks for looking into this. This works for the component build, but unfortunately now fails ...
7 years, 2 months ago (2013-10-04 14:42:08 UTC) #2
rmcilroy
lgtm As discussed offline, this does actually work. Thanks!
7 years, 2 months ago (2013-10-04 14:52:37 UTC) #3
Jakob Kummerow
7 years, 2 months ago (2013-10-04 14:53:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r17109.

Powered by Google App Engine
This is Rietveld 408576698