Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: tools/gyp/v8.gyp

Issue 26004003: Fix shared_library build after r17107 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/unicode.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index 83549ddf6cdf737ff96b906331f2691dd6a963b7..bb9abc96fb3525b3a9688f06db6a7895efbe83f0 100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -58,13 +58,10 @@
['component=="shared_library"', {
'type': '<(component)',
'sources': [
+ '../../src/defaults.cc',
rmcilroy 2013/10/04 14:42:08 I think you need this in the v8 target for both "c
# Note: on non-Windows we still build this file so that gyp
# has some sources to link into the component.
'../../src/v8dll-main.cc',
- '../../src/defaults.cc',
- ],
- 'include_dirs': [
- '../../include',
],
rmcilroy 2013/10/04 14:42:08 if you do: 'include_dirs': [ '../../src', ],
'defines': [
'V8_SHARED',
@@ -274,7 +271,6 @@
'../../src/debug-agent.h',
'../../src/debug.cc',
'../../src/debug.h',
- '../../src/defaults.cc',
'../../src/deoptimizer.cc',
'../../src/deoptimizer.h',
'../../src/disasm.h',
@@ -858,6 +854,10 @@
'BUILDING_V8_SHARED',
'V8_SHARED',
],
+ }, {
+ 'sources': [
+ '../../src/defaults.cc',
+ ],
}],
['v8_postmortem_support=="true"', {
'sources': [
« no previous file with comments | « src/unicode.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698