Fix shared_library build after r17107

tools/gyp/v8.gyp

 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 40 matching lines @@
           # dependency however the Android toolchain requires libv8_base.a
           # to appear before libv8_snapshot.a so it's listed explicitly.
           'dependencies': [
             'v8_base.<(v8_target_arch)',
             'v8_nosnapshot.<(v8_target_arch)',
           ],
         }],
         ['component=="shared_library"', {
           'type': '<(component)',
           'sources': [
+            '../../src/defaults.cc',

[rmcilroy, 2013/10/04 14:42:08]

I think you need this in the v8 target for both "component"="shared_library" and
otherwise (i.e., include this source file unconditionally in this target). This
now works for the component build, but not for the single lib chromium build.

             # Note: on non-Windows we still build this file so that gyp
             # has some sources to link into the component.
             '../../src/v8dll-main.cc',
-            '../../src/defaults.cc',
-          ],
-          'include_dirs': [
-            '../../include',
           ],

[rmcilroy, 2013/10/04 14:42:08]

if you do:
'include_dirs': [	
   '../../src',	
],

you can avoid the header file include changes.

           'defines': [
             'V8_SHARED',
             'BUILDING_V8_SHARED',
           ],
           'direct_dependent_settings': {
             'defines': [
               'V8_SHARED',
               'USING_V8_SHARED',
             ],
           },
@@ skipping 188 matching lines @@
         '../../src/data-flow.h',
         '../../src/date.cc',
         '../../src/date.h',
         '../../src/dateparser-inl.h',
         '../../src/dateparser.cc',
         '../../src/dateparser.h',
         '../../src/debug-agent.cc',
         '../../src/debug-agent.h',
         '../../src/debug.cc',
         '../../src/debug.h',
-        '../../src/defaults.cc',
         '../../src/deoptimizer.cc',
         '../../src/deoptimizer.h',
         '../../src/disasm.h',
         '../../src/disassembler.cc',
         '../../src/disassembler.h',
         '../../src/diy-fp.cc',
         '../../src/diy-fp.h',
         '../../src/double.h',
         '../../src/dtoa.cc',
         '../../src/dtoa.h',
@@ skipping 563 matching lines @@
                 'libraries': [ '-lwinmm.lib', '-lws2_32.lib' ],
               },
             }],
           ],
         }],
         ['component=="shared_library"', {
           'defines': [
             'BUILDING_V8_SHARED',
             'V8_SHARED',
           ],
+        }, {
+          'sources': [
+            '../../src/defaults.cc',
+          ],
         }],
         ['v8_postmortem_support=="true"', {
           'sources': [
             '<(SHARED_INTERMEDIATE_DIR)/debug-support.cc',
           ]
         }],
         ['v8_enable_i18n_support==1', {
           'dependencies': [
             '<(icu_gyp_path):icui18n',
             '<(icu_gyp_path):icuuc',
@@ skipping 180 matching lines @@
         }],
         ['v8_compress_startup_data=="bz2"', {
           'libraries': [
             '-lbz2',
           ]
         }],
       ],
     },
   ],
 }