Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2600323002: DevTools: extract protocol module (Closed)

Created:
3 years, 11 months ago by chenwilliam
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: extract protocol module InspectorBackendClass => Protocol.InspectorBackend InspectorBackend => Protocol.inspectorBackend BUG=none Committed: https://crrev.com/d904186f90ab5b297677e8ce16849a5da903bc63 Cr-Commit-Position: refs/heads/master@{#440883}

Patch Set 1 #

Patch Set 2 : REVERT namespaces.js #

Patch Set 3 : move inspector backend commands.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -825 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/protocol-test.js View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt View 5 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/inspector-backend-commands.html View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/open-with-rendering-option-enabled-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/report-protocol-errors.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/externs.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/layers/LayerTreeModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js View 20 chunks +50 lines, -50 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/protocol/module.json View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Connections.js View 5 chunks +8 lines, -8 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js View 1 chunk +0 lines, -728 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/PaintProfiler.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Target.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/module.json View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/build/code_generator_frontend.py View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/compile_frontend.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
chenwilliam
PTAL. You can look at patchset 1 for the namespaces.js script I used to do ...
3 years, 11 months ago (2016-12-28 18:24:42 UTC) #3
dgozman
lgtm
3 years, 11 months ago (2016-12-28 18:39:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600323002/10027
3 years, 11 months ago (2016-12-28 18:43:47 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:10027)
3 years, 11 months ago (2016-12-28 20:09:50 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:50:01 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d904186f90ab5b297677e8ce16849a5da903bc63
Cr-Commit-Position: refs/heads/master@{#440883}

Powered by Google App Engine
This is Rietveld 408576698