Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Issue 2600323002: DevTools: extract protocol module (Closed)
Patch Set: move inspector backend commands.js Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
index 09497a0d88bbf727dc145beb63db599c0d2db6e3..e170ff5a3fed8d652ddc2b21bdceaaf552255a42 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
@@ -157,7 +157,7 @@ SDK.TargetManager = class extends Common.Object {
/**
* @param {string} name
* @param {number} capabilitiesMask
- * @param {!InspectorBackendClass.Connection.Factory} connectionFactory
+ * @param {!Protocol.InspectorBackend.Connection.Factory} connectionFactory
* @param {?SDK.Target} parentTarget
* @return {!SDK.Target}
*/
@@ -354,8 +354,8 @@ SDK.TargetManager = class extends Common.Object {
}
/**
- * @param {!InspectorBackendClass.Connection.Params} params
- * @return {!InspectorBackendClass.Connection}
+ * @param {!Protocol.InspectorBackend.Connection.Params} params
+ * @return {!Protocol.InspectorBackend.Connection}
*/
_createMainConnection(params) {
if (Runtime.queryParam('ws')) {
@@ -371,7 +371,7 @@ SDK.TargetManager = class extends Common.Object {
/**
* @param {function(string)} onMessage
- * @return {!Promise<!InspectorBackendClass.Connection>}
+ * @return {!Promise<!Protocol.InspectorBackend.Connection>}
*/
interceptMainConnection(onMessage) {
var params = {onMessage: onMessage, onDisconnect: this._connectAndCreateMainTarget.bind(this)};

Powered by Google App Engine
This is Rietveld 408576698