Remove context param from PhysicalWebUma methods

Remove context param from PhysicalWebUma methods

This parameter has done nothing for a while.  It became obsolete when
we started using ContextUtils.getAppSharedPreferences().

BUG=678787
Review-Url: https://codereview.chromium.org/2600283002
Cr-Commit-Position: refs/heads/master@{#442006}
Committed: https://chromium.googlesource.com/chromium/src/+/9909a9f963c17a4ae2342303fe5971e54e38ef46

[cco3, 2017-01-05 19:43:19]

cco3@chromium.org changed reviewers:
+ mattreynolds@chromium.org

[mattreynolds, 2017-01-05 20:01:12]

lgtm

https://codereview.chromium.org/2600283002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
(left):

https://codereview.chromium.org/2600283002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java:10:

Remove newline (go/java-imports says to put all non-static imports in the same
block)

[cco3, 2017-01-05 20:20:09]

cco3@chromium.org changed reviewers:
+ nyquist@chromium.org

[cco3, 2017-01-05 20:20:10]

Hi nyquist@, do you have time to take a look at this cleanup change?

https://codereview.chromium.org/2600283002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
(left):

https://codereview.chromium.org/2600283002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java:10:

On 2017/01/05 20:01:12, mattreynolds wrote:
> Remove newline (go/java-imports says to put all non-static imports in the same
> block)
> 

Presubmit check says otherwise for chromium.

[nyquist, 2017-01-05 22:00:02]

lgtm.
is there a bug for this? If not, add BUG=None ?

[cco3, 2017-01-05 22:40:06]

Description was changed from

==========
Remove context param from PhysicalWebUma methods

This parameter has done nothing for a while.  It became obsolete when
we started using ContextUtils.getAppSharedPreferences().
==========

to

==========
Remove context param from PhysicalWebUma methods

This parameter has done nothing for a while.  It became obsolete when
we started using ContextUtils.getAppSharedPreferences().

BUG=678787
==========

[cco3, 2017-01-05 22:41:47]

On 2017/01/05 22:00:02, nyquist wrote:
> lgtm.
> is there a bug for this? If not, add BUG=None ?

Done

[cco3, 2017-01-05 22:42:09]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-05 22:42:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2600283002/#ps20001
(title: "Add bug #")

[commit-bot: I haz the power, 2017-01-05 22:42:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 01:38:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 01:38:24]

Failed to apply patch for
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:
While running git apply --index -p1;
  error: patch failed:
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:509
  error:
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:
patch does not apply

Patch:      
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
Index:
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
diff --git
a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
index
e27a634d46b74b5050b77f94945df15ff9b3f072..02add182b1a73143f3131542cb1ef779bff9b7ba
100644
---
a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
+++
b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
@@ -509,7 +509,7 @@ class UrlManager {
             @Override
             public void onPwsResults(final Collection<PwsResult> pwsResults) {
                 long duration = SystemClock.elapsedRealtime() - timestamp;
-                PhysicalWebUma.onBackgroundPwsResolution(mContext, duration);
+                PhysicalWebUma.onBackgroundPwsResolution(duration);
                 new Handler(Looper.getMainLooper()).post(new Runnable() {
                     @Override
                     public void run() {
@@ -561,11 +561,11 @@ class UrlManager {
                 // high priority notification
                 createOptInNotification(true);
                 PhysicalWeb.recordOptInNotification();
-                PhysicalWebUma.onOptInHighPriorityNotificationShown(mContext);
+                PhysicalWebUma.onOptInHighPriorityNotificationShown();
             } else {
                 // min priority notification
                 createOptInNotification(false);
-                PhysicalWebUma.onOptInMinPriorityNotificationShown(mContext);
+                PhysicalWebUma.onOptInMinPriorityNotificationShown();
             }
         } else if (PhysicalWeb.isPhysicalWebPreferenceEnabled()) {
             createNotification();

[cco3, 2017-01-06 18:26:36]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-06 18:26:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2600283002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-06 18:26:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 19:28:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483727196469720,
"parent_rev": "eb2ee1c57a729c7dc4e4172b380f0c85cf364d42", "commit_rev":
"9909a9f963c17a4ae2342303fe5971e54e38ef46"}

[commit-bot: I haz the power, 2017-01-06 19:28:31]

Description was changed from

==========
Remove context param from PhysicalWebUma methods

This parameter has done nothing for a while.  It became obsolete when
we started using ContextUtils.getAppSharedPreferences().

BUG=678787
==========

to

==========
Remove context param from PhysicalWebUma methods

This parameter has done nothing for a while.  It became obsolete when
we started using ContextUtils.getAppSharedPreferences().

BUG=678787

Review-Url: https://codereview.chromium.org/2600283002
Cr-Commit-Position: refs/heads/master@{#442006}
Committed:
https://chromium.googlesource.com/chromium/src/+/9909a9f963c17a4ae2342303fe59...
==========

[commit-bot: I haz the power, 2017-01-06 19:28:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9909a9f963c17a4ae2342303fe59...