Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2977)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java

Issue 2600283002: Remove context param from PhysicalWebUma methods (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebOptInActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
index 6e80ab607eb9b7303c1e627b215feb6d9c6e5701..8c9f8d41d6da638334e528a443526d58c05082f9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
@@ -121,7 +121,7 @@ public class ListUrlsActivity extends AppCompatActivity implements AdapterView.O
mPwsClient = new PwsClientImpl(this);
int referer = getIntent().getIntExtra(REFERER_KEY, 0);
if (savedInstanceState == null) { // Ensure this is a newly-created activity.
- PhysicalWebUma.onActivityReferral(this, referer);
+ PhysicalWebUma.onActivityReferral(referer);
}
mIsInitialDisplayRecorded = false;
mIsRefreshing = false;
@@ -211,9 +211,9 @@ public class ListUrlsActivity extends AppCompatActivity implements AdapterView.O
public void onPwsResults(Collection<PwsResult> pwsResults) {
long duration = SystemClock.elapsedRealtime() - timestamp;
if (isUserInitiated) {
- PhysicalWebUma.onRefreshPwsResolution(ListUrlsActivity.this, duration);
+ PhysicalWebUma.onRefreshPwsResolution(duration);
} else {
- PhysicalWebUma.onForegroundPwsResolution(ListUrlsActivity.this, duration);
+ PhysicalWebUma.onForegroundPwsResolution(duration);
}
// filter out duplicate groups.
@@ -241,7 +241,7 @@ public class ListUrlsActivity extends AppCompatActivity implements AdapterView.O
*/
@Override
public void onItemClick(AdapterView<?> adapterView, View view, int position, long id) {
- PhysicalWebUma.onUrlSelected(this);
+ PhysicalWebUma.onUrlSelected();
UrlInfo nearestUrlInfo = null;
PwsResult nearestPwsResult = mAdapter.getItem(position);
String groupId = nearestPwsResult.groupId;
@@ -326,9 +326,9 @@ public class ListUrlsActivity extends AppCompatActivity implements AdapterView.O
// Record refresh-related UMA.
if (!mIsInitialDisplayRecorded) {
mIsInitialDisplayRecorded = true;
- PhysicalWebUma.onUrlsDisplayed(this, mAdapter.getCount());
+ PhysicalWebUma.onUrlsDisplayed(mAdapter.getCount());
} else if (mIsRefreshUserInitiated) {
- PhysicalWebUma.onUrlsRefreshed(this, mAdapter.getCount());
+ PhysicalWebUma.onUrlsRefreshed(mAdapter.getCount());
}
mIsRefreshing = false;
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebOptInActivity.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698