Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2600223003: Made _UpdateSuspect a method on Suspect rather than a standalone function (Closed)

Created:
3 years, 12 months ago by wrengr
Modified:
3 years, 12 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Made _UpdateSuspect a method on Suspect rather than a standalone function BUG= TBR=stgao@chromium.org Review-Url: https://codereview.chromium.org/2600223003 Committed: https://chromium.googlesource.com/infra/infra/+/5b0e83da43413d1ba5e12a51e7b9998cd00f5f79

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -50 lines) Patch
M appengine/findit/crash/suspect.py View 2 chunks +47 lines, -44 lines 0 comments Download
M appengine/findit/crash/test/suspect_test.py View 6 chunks +5 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
wrengr
PTAL
3 years, 12 months ago (2016-12-27 20:54:14 UTC) #3
inferno
lgtm
3 years, 12 months ago (2016-12-27 21:00:33 UTC) #4
Sharu Jiang
lgtm
3 years, 12 months ago (2016-12-27 21:05:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600223003/1
3 years, 12 months ago (2016-12-27 21:42:22 UTC) #7
commit-bot: I haz the power
3 years, 12 months ago (2016-12-27 21:51:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/5b0e83da43413d1ba5e12a51e7b99...

Powered by Google App Engine
This is Rietveld 408576698