Made _UpdateSuspect a method on Suspect rather than a standalone function

appengine/findit/crash/test/suspect_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from crash.stacktrace import StackFrame
 from crash.suspect import AnalysisInfo
 from crash.suspect import StackInfo
 from crash.suspect import Suspect
 from crash.suspect import SuspectMap
-from crash.suspect import _UpdateSuspect
 from crash.test.crash_test_suite import CrashTestSuite
 from libs.gitiles.blame import Blame
 from libs.gitiles.blame import Region
 from libs.gitiles.change_log import ChangeLog
 
 DUMMY_CHANGELOG1 = ChangeLog.FromDict({
     'author_name': 'r@chromium.org',
     'message': 'dummy',
     'committer_email': 'r@chromium.org',
     'commit_position': 175900,
@@ skipping 95 matching lines @@
 
     self.assertEqual(str(suspect), expected_str)
 
   def testSuspectUpdate(self):
     # Touched lines have intersection with crashed lines.
     suspect = Suspect(DUMMY_CHANGELOG1, 'src/', confidence=1)
     stack_infos = [StackInfo(
         frame = StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [7]),
         priority = 0)]
 
-    _UpdateSuspect(suspect, 'a.cc', stack_infos, DUMMY_BLAME)
+    suspect._UpdateSuspect('a.cc', stack_infos, DUMMY_BLAME)
     self.assertEqual(suspect.file_to_analysis_info['a.cc'].min_distance, 0)
 
     # Touched lines are before crashed lines.
     suspect = Suspect(DUMMY_CHANGELOG1, 'src/', confidence=1)
 
     stack_infos = [StackInfo(
         frame = StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [3]),
         priority = 0)]
 
-    _UpdateSuspect(suspect, 'a.cc', stack_infos, DUMMY_BLAME)
+    suspect._UpdateSuspect('a.cc', stack_infos, DUMMY_BLAME)
     self.assertEqual(suspect.file_to_analysis_info['a.cc'].min_distance, 3)
 
     # Touched lines are after crashed lines.
     suspect = Suspect(DUMMY_CHANGELOG1, 'src/', confidence=1)
 
     stack_infos = [StackInfo(
         frame = StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [10]),
         priority = 0)]
 
-    _UpdateSuspect(suspect, 'a.cc', stack_infos, DUMMY_BLAME)
+    suspect._UpdateSuspect('a.cc', stack_infos, DUMMY_BLAME)
     self.assertEqual(suspect.file_to_analysis_info['a.cc'].min_distance, 2)
 
   def testSuspectUpdateWithEmptyBlame(self):
     suspect = Suspect(DUMMY_CHANGELOG1, 'src/', confidence=1)
     stack_infos = [StackInfo(
         frame = StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [7]),
         priority = 0)]
 
-    _UpdateSuspect(suspect, 'a.cc', stack_infos, None)
+    suspect._UpdateSuspect('a.cc', stack_infos, None)
     self.assertEqual(suspect.file_to_stack_infos['a.cc'], stack_infos)
     self.assertEqual(suspect.file_to_analysis_info, {})
 
   def testSuspectUpdateMinimumDistance(self):
     suspect = Suspect(DUMMY_CHANGELOG1, 'src/', confidence=1)
     frame1 = StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [7])
     frame2 = StackFrame(2, 'src/', 'func', 'a.cc', 'src/a.cc', [20])
     stack_infos = [StackInfo(frame1, 0), StackInfo(frame2, 0)]
 
-    _UpdateSuspect(suspect, 'a.cc', stack_infos, DUMMY_BLAME)
+    suspect._UpdateSuspect('a.cc', stack_infos, DUMMY_BLAME)
     self.assertEqual(suspect.file_to_stack_infos['a.cc'], stack_infos)
     self.assertEqual(suspect.file_to_analysis_info,
         {'a.cc': AnalysisInfo(min_distance = 0, min_distance_frame = frame1)})
 
   def testSuspectsGenerateSuspects(self):
     suspects = SuspectMap(ignore_cls=set(['2']))
     frame1 = StackFrame(0, 'src/',  'func', 'a.cc', 'src/a.cc', [7])
     frame2 = StackFrame(1, 'src/',  'func', 'b.cc', 'src/b.cc', [11])
     stack_infos1 = [StackInfo(frame1, 0)]
     stack_infos2 = [StackInfo(frame2, 0)]
@@ skipping 12 matching lines @@
     }
     expected_suspect.file_to_analysis_info = {
         'a.cc': AnalysisInfo(min_distance = 0, min_distance_frame = frame1),
         'b.cc': AnalysisInfo(min_distance = 3, min_distance_frame = frame2),
     }
 
     expected_suspects = SuspectMap(ignore_cls=set(['2']))
     expected_suspects['1'] = expected_suspect
 
     self._VerifyTwoSuspectMapEqual(suspects, expected_suspects)