Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2600163002:
SharedWorker: Clarify that SharedWorkerRepository is owned by RenderFrameImpl (Closed)
|
Created:
3 years, 12 months ago by nhiroki Modified:
3 years, 11 months ago Reviewers:
kinuko CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSharedWorker: Clarify that SharedWorkerRepository is owned by RenderFrameImpl
Before this CL, SharedWorkerRepository is implicitly owned by RenderFrameImpl.
It's created when RenderFrameImpl is initialized and destructed on
RenderFrameObserver::OnDestruct called from the dtor of RenderFrameImpl. This
looks confusing.
After this CL, RenderFrameImpl explicitly owns SharedWorkerRepository as its
member field. This should not change behavior.
BUG=612308
Committed: https://crrev.com/bf678987c37ca0fb32515321216bb6b6c7ae76ad
Cr-Commit-Position: refs/heads/master@{#440734}
Patch Set 1 #Patch Set 2 : fix test crashes #Patch Set 3 : rebase #
Messages
Total messages: 25 (20 generated)
Description was changed from ========== SharedWorker: Clarify that SharedWorkerRepository has the same lifetime with RenderFrameImpl BUG=612308 ========== to ========== SharedWorker: Clarify that SharedWorkerRepository has the same lifetime with RenderFrameImpl Before this CL, SharedWorkerRepository is implicitly owned by RenderFrameImpl. It's created when RenderFrameImpl is initialized and destructed on the dtor of RenderFrameImpl via RenderFrameObserver::OnDestruct. This is not obvious. After this CL, RenderFrameImpl explicitly owns SharedWorkerRepository as its member field. This should not change behavior. BUG=612308 ==========
Description was changed from ========== SharedWorker: Clarify that SharedWorkerRepository has the same lifetime with RenderFrameImpl Before this CL, SharedWorkerRepository is implicitly owned by RenderFrameImpl. It's created when RenderFrameImpl is initialized and destructed on the dtor of RenderFrameImpl via RenderFrameObserver::OnDestruct. This is not obvious. After this CL, RenderFrameImpl explicitly owns SharedWorkerRepository as its member field. This should not change behavior. BUG=612308 ========== to ========== SharedWorker: Clarify that SharedWorkerRepository is owned by RenderFrameImpl Before this CL, SharedWorkerRepository is implicitly owned by RenderFrameImpl. It's created when RenderFrameImpl is initialized and destructed on the dtor of RenderFrameImpl via RenderFrameObserver::OnDestruct. This is not obvious. After this CL, RenderFrameImpl explicitly owns SharedWorkerRepository as its member field. This should not change behavior. BUG=612308 ==========
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== SharedWorker: Clarify that SharedWorkerRepository is owned by RenderFrameImpl Before this CL, SharedWorkerRepository is implicitly owned by RenderFrameImpl. It's created when RenderFrameImpl is initialized and destructed on the dtor of RenderFrameImpl via RenderFrameObserver::OnDestruct. This is not obvious. After this CL, RenderFrameImpl explicitly owns SharedWorkerRepository as its member field. This should not change behavior. BUG=612308 ========== to ========== SharedWorker: Clarify that SharedWorkerRepository is owned by RenderFrameImpl Before this CL, SharedWorkerRepository is implicitly owned by RenderFrameImpl. It's created when RenderFrameImpl is initialized and destructed on the dtor of RenderFrameImpl. This looks confusing. After this CL, RenderFrameImpl explicitly owns SharedWorkerRepository as its member field. This should not change behavior. BUG=612308 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== SharedWorker: Clarify that SharedWorkerRepository is owned by RenderFrameImpl Before this CL, SharedWorkerRepository is implicitly owned by RenderFrameImpl. It's created when RenderFrameImpl is initialized and destructed on the dtor of RenderFrameImpl. This looks confusing. After this CL, RenderFrameImpl explicitly owns SharedWorkerRepository as its member field. This should not change behavior. BUG=612308 ========== to ========== SharedWorker: Clarify that SharedWorkerRepository is owned by RenderFrameImpl Before this CL, SharedWorkerRepository is implicitly owned by RenderFrameImpl. It's created when RenderFrameImpl is initialized and destructed on RenderFrameObserver::OnDestruct. This looks confusing. After this CL, RenderFrameImpl explicitly owns SharedWorkerRepository as its member field. This should not change behavior. BUG=612308 ==========
Description was changed from ========== SharedWorker: Clarify that SharedWorkerRepository is owned by RenderFrameImpl Before this CL, SharedWorkerRepository is implicitly owned by RenderFrameImpl. It's created when RenderFrameImpl is initialized and destructed on RenderFrameObserver::OnDestruct. This looks confusing. After this CL, RenderFrameImpl explicitly owns SharedWorkerRepository as its member field. This should not change behavior. BUG=612308 ========== to ========== SharedWorker: Clarify that SharedWorkerRepository is owned by RenderFrameImpl Before this CL, SharedWorkerRepository is implicitly owned by RenderFrameImpl. It's created when RenderFrameImpl is initialized and destructed on RenderFrameObserver::OnDestruct called from the dtor of RenderFrameImpl. This looks confusing. After this CL, RenderFrameImpl explicitly owns SharedWorkerRepository as its member field. This should not change behavior. BUG=612308 ==========
nhiroki@chromium.org changed reviewers: + kinuko@chromium.org
PTAL, thanks!
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nhiroki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482816767426900,
"parent_rev": "3d0a1d2a99f4fbbc8b7108caba6df0a9a23435ef", "commit_rev":
"c8790256542eb8d38bd768c86e6abffa8b5512bb"}
Message was sent while issue was closed.
Description was changed from ========== SharedWorker: Clarify that SharedWorkerRepository is owned by RenderFrameImpl Before this CL, SharedWorkerRepository is implicitly owned by RenderFrameImpl. It's created when RenderFrameImpl is initialized and destructed on RenderFrameObserver::OnDestruct called from the dtor of RenderFrameImpl. This looks confusing. After this CL, RenderFrameImpl explicitly owns SharedWorkerRepository as its member field. This should not change behavior. BUG=612308 ========== to ========== SharedWorker: Clarify that SharedWorkerRepository is owned by RenderFrameImpl Before this CL, SharedWorkerRepository is implicitly owned by RenderFrameImpl. It's created when RenderFrameImpl is initialized and destructed on RenderFrameObserver::OnDestruct called from the dtor of RenderFrameImpl. This looks confusing. After this CL, RenderFrameImpl explicitly owns SharedWorkerRepository as its member field. This should not change behavior. BUG=612308 Review-Url: https://codereview.chromium.org/2600163002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== SharedWorker: Clarify that SharedWorkerRepository is owned by RenderFrameImpl Before this CL, SharedWorkerRepository is implicitly owned by RenderFrameImpl. It's created when RenderFrameImpl is initialized and destructed on RenderFrameObserver::OnDestruct called from the dtor of RenderFrameImpl. This looks confusing. After this CL, RenderFrameImpl explicitly owns SharedWorkerRepository as its member field. This should not change behavior. BUG=612308 Review-Url: https://codereview.chromium.org/2600163002 ========== to ========== SharedWorker: Clarify that SharedWorkerRepository is owned by RenderFrameImpl Before this CL, SharedWorkerRepository is implicitly owned by RenderFrameImpl. It's created when RenderFrameImpl is initialized and destructed on RenderFrameObserver::OnDestruct called from the dtor of RenderFrameImpl. This looks confusing. After this CL, RenderFrameImpl explicitly owns SharedWorkerRepository as its member field. This should not change behavior. BUG=612308 Committed: https://crrev.com/bf678987c37ca0fb32515321216bb6b6c7ae76ad Cr-Commit-Position: refs/heads/master@{#440734} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/bf678987c37ca0fb32515321216bb6b6c7ae76ad Cr-Commit-Position: refs/heads/master@{#440734} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
