Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: content/renderer/shared_worker_repository.h

Issue 2600163002: SharedWorker: Clarify that SharedWorkerRepository is owned by RenderFrameImpl (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/shared_worker_repository.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/shared_worker_repository.h
diff --git a/content/renderer/shared_worker_repository.h b/content/renderer/shared_worker_repository.h
index cfc98dd51f7acc801c23bae5bb95fe2dd71ba157..c4dffb2fedc367d3013bffb82183eea989c7bce0 100644
--- a/content/renderer/shared_worker_repository.h
+++ b/content/renderer/shared_worker_repository.h
@@ -9,7 +9,6 @@
#include <set>
#include "base/macros.h"
-#include "content/public/renderer/render_frame_observer.h"
#include "third_party/WebKit/public/platform/WebAddressSpace.h"
#include "third_party/WebKit/public/web/WebContentSecurityPolicy.h"
#include "third_party/WebKit/public/web/WebSharedWorkerCreationContextType.h"
@@ -19,11 +18,11 @@ namespace content {
class RenderFrameImpl;
-class SharedWorkerRepository : public RenderFrameObserver,
- public blink::WebSharedWorkerRepositoryClient {
+class SharedWorkerRepository final
+ : public blink::WebSharedWorkerRepositoryClient {
public:
explicit SharedWorkerRepository(RenderFrameImpl* render_frame);
- ~SharedWorkerRepository() override;
+ ~SharedWorkerRepository();
// WebSharedWorkerRepositoryClient overrides.
std::unique_ptr<blink::WebSharedWorkerConnector> createSharedWorkerConnector(
@@ -38,9 +37,7 @@ class SharedWorkerRepository : public RenderFrameObserver,
void documentDetached(DocumentID document_id) override;
private:
- // RenderFrameObserver implementation.
- void OnDestruct() override;
-
+ RenderFrameImpl* render_frame_;
std::set<DocumentID> documents_with_workers_;
DISALLOW_COPY_AND_ASSIGN(SharedWorkerRepository);
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/shared_worker_repository.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698