Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2600113002: Initialize arrays before use. (Closed)

Created:
3 years, 12 months ago by apisarev
Modified:
3 years, 11 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize arrays before use. In edited code is possible usage of not initialized array. It's caused by reason, that GetProgramInfoLog and GetShaderInfoLog functions can end without filling of the passed array. This error can be detected by MSan. To fix this problem arrays was initialized before being passed and printed. R=aelias@chromium.org BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/99cf9c1f9098c0781f3cc5e468e14f7010d68caf Cr-Commit-Position: refs/heads/master@{#440964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M cc/output/program_binding.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
apisarev
3 years, 12 months ago (2016-12-26 15:29:35 UTC) #4
danakj
LGTM
3 years, 11 months ago (2016-12-29 16:21:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600113002/1
3 years, 11 months ago (2016-12-29 16:21:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 17:16:15 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:52:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99cf9c1f9098c0781f3cc5e468e14f7010d68caf
Cr-Commit-Position: refs/heads/master@{#440964}

Powered by Google App Engine
This is Rietveld 408576698