Chromium Code Reviews
DescriptionRevert of Document that HistoryBackend is sequence-affine, not thread-affine. (patchset #2 id:20001 of https://codereview.chromium.org/2591123004/ )
Reason for revert:
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/20846/steps/browser_tests/logs/ProfileBrowserTest.OffTheRecordURLRequestContextIsolation
The CL causes the browser_tests failure on Linux ChromiumOS Tests(dbg)
Original issue's description:
> Document that HistoryBackend is sequence-affine, not thread-affine.
>
> HistoryBackend methods must not be called concurrently and external
> synchronization is required between calls on different thread.
> However, the methods do not have to be called from a single thread.
> This CL documents this and adds DCHECKs to verify that
> HistoryBackend methods are called in sequence.
>
> BUG=675800, 675631
>
> Committed: https://crrev.com/0b0b5aab6e2474e0e758ca3777b07321e59a7463
> Cr-Commit-Position: refs/heads/master@{#440408}
TBR=sdefresne@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675800, 675631
Committed: https://crrev.com/cc870ed0d9a16f478dd5e2f584ed19b749f2729f
Cr-Commit-Position: refs/heads/master@{#440441}
Patch Set 1 #
Messages
Total messages: 8 (4 generated)
|
|||||||||||||||||||||||||||||||||||||