Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2599803002: Revert of Document that HistoryBackend is sequence-affine, not thread-affine. (Closed)

Created:
4 years ago by Peng
Modified:
4 years ago
Reviewers:
fdoray, sdefresne
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Document that HistoryBackend is sequence-affine, not thread-affine. (patchset #2 id:20001 of https://codereview.chromium.org/2591123004/ ) Reason for revert: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/20846/steps/browser_tests/logs/ProfileBrowserTest.OffTheRecordURLRequestContextIsolation The CL causes the browser_tests failure on Linux ChromiumOS Tests(dbg) Original issue's description: > Document that HistoryBackend is sequence-affine, not thread-affine. > > HistoryBackend methods must not be called concurrently and external > synchronization is required between calls on different thread. > However, the methods do not have to be called from a single thread. > This CL documents this and adds DCHECKs to verify that > HistoryBackend methods are called in sequence. > > BUG=675800, 675631 > > Committed: https://crrev.com/0b0b5aab6e2474e0e758ca3777b07321e59a7463 > Cr-Commit-Position: refs/heads/master@{#440408} TBR=sdefresne@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=675800, 675631 Committed: https://crrev.com/cc870ed0d9a16f478dd5e2f584ed19b749f2729f Cr-Commit-Position: refs/heads/master@{#440441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -190 lines) Patch
M components/browser_sync/profile_sync_service_typed_url_unittest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M components/history/core/browser/history_backend.h View 4 chunks +9 lines, -10 lines 0 comments Download
M components/history/core/browser/history_backend.cc View 82 chunks +0 lines, -173 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Peng
Created Revert of Document that HistoryBackend is sequence-affine, not thread-affine.
4 years ago (2016-12-22 16:54:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599803002/1
4 years ago (2016-12-22 16:54:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 16:55:38 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-22 16:59:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc870ed0d9a16f478dd5e2f584ed19b749f2729f
Cr-Commit-Position: refs/heads/master@{#440441}

Powered by Google App Engine
This is Rietveld 408576698