Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: components/browser_sync/profile_sync_service_typed_url_unittest.cc

Issue 2599803002: Revert of Document that HistoryBackend is sequence-affine, not thread-affine. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/history/core/browser/history_backend.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_sync/profile_sync_service_typed_url_unittest.cc
diff --git a/components/browser_sync/profile_sync_service_typed_url_unittest.cc b/components/browser_sync/profile_sync_service_typed_url_unittest.cc
index 8e72b88d68310e1ae8a8ce5da160396c9070f00d..da6c619b817cc37ef0839c5b8ce35ada11bdabbb 100644
--- a/components/browser_sync/profile_sync_service_typed_url_unittest.cc
+++ b/components/browser_sync/profile_sync_service_typed_url_unittest.cc
@@ -112,8 +112,6 @@
~HistoryServiceMock() override {}
- void ReleaseBackend() { backend_ = nullptr; }
-
void set_task_runner(
scoped_refptr<base::SingleThreadTaskRunner> task_runner) {
DCHECK(task_runner.get());
@@ -212,11 +210,6 @@
~ProfileSyncServiceTypedUrlTest() override {
history_service_->Shutdown();
-
- // Release the HistoryBackend so it's deleted on data_type_thread() as part
- // of DeleteSyncableService() instead of on the main thread when
- // HistoryService is deleted.
- history_service_->ReleaseBackend();
// Request stop to get deletion tasks related to the HistoryService posted
// on the Sync thread. It is important to not Shutdown at this moment,
« no previous file with comments | « no previous file | components/history/core/browser/history_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698