Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2599713002: Use explicit WebString <-> string{16,} conversion methods in content/renderer/pepper (Closed)

Created:
3 years, 12 months ago by kinuko
Modified:
3 years, 11 months ago
Reviewers:
raymes
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use explicit WebString string conversion methods in content/renderer/pepper As we're deprecating implicit conversions for WebString <-> string16 replace them with explicit methods. (See crbug.com/667131 for more details) BUG=667131 Committed: https://crrev.com/b80f567c1f3e1a9b9cf8215d6c534be9e032a213 Cr-Commit-Position: refs/heads/master@{#440732}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M content/renderer/pepper/host_globals.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.cc View 1 1 chunk +2 lines, -2 lines 1 comment Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/ppb_graphics_3d_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/url_request_info_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
kinuko
PTL https://codereview.chromium.org/2599713002/diff/20001/content/renderer/pepper/pepper_media_stream_video_track_host.cc File content/renderer/pepper/pepper_media_stream_video_track_host.cc (right): https://codereview.chromium.org/2599713002/diff/20001/content/renderer/pepper/pepper_media_stream_video_track_host.cc#newcode522 content/renderer/pepper/pepper_media_stream_video_track_host.cc:522: blink::WebString::fromASCII(kPepperVideoSourceName), Looks like source_id (which is base64 encoded ...
3 years, 12 months ago (2016-12-22 06:53:21 UTC) #3
raymes
lgtm
3 years, 11 months ago (2016-12-27 04:01:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599713002/20001
3 years, 11 months ago (2016-12-27 04:15:45 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2016-12-27 05:13:05 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:45:32 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b80f567c1f3e1a9b9cf8215d6c534be9e032a213
Cr-Commit-Position: refs/heads/master@{#440732}

Powered by Google App Engine
This is Rietveld 408576698