Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.cc

Issue 2599713002: Use explicit WebString <-> string{16,} conversion methods in content/renderer/pepper (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/pepper_plugin_instance_impl.cc
diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.cc b/content/renderer/pepper/pepper_plugin_instance_impl.cc
index c039d254d2bef13c6a7e6c3998a6a8293b7c5b52..2ce23d61246c037f8bbef2ccb265c8325d86942b 100644
--- a/content/renderer/pepper/pepper_plugin_instance_impl.cc
+++ b/content/renderer/pepper/pepper_plugin_instance_impl.cc
@@ -1456,7 +1456,7 @@ void PepperPluginInstanceImpl::RequestSurroundingText(
pp_instance(), desired_number_of_characters);
}
-bool PepperPluginInstanceImpl::StartFind(const base::string16& search_text,
+bool PepperPluginInstanceImpl::StartFind(const std::string& search_text,
bool case_sensitive,
int identifier) {
// Keep a reference on the stack. See NOTE above.
@@ -1464,10 +1464,8 @@ bool PepperPluginInstanceImpl::StartFind(const base::string16& search_text,
if (!LoadFindInterface())
return false;
find_identifier_ = identifier;
- return PP_ToBool(
- plugin_find_interface_->StartFind(pp_instance(),
- base::UTF16ToUTF8(search_text).c_str(),
- PP_FromBool(case_sensitive)));
+ return PP_ToBool(plugin_find_interface_->StartFind(
+ pp_instance(), search_text.c_str(), PP_FromBool(case_sensitive)));
}
void PepperPluginInstanceImpl::SelectFindResult(bool forward, int identifier) {

Powered by Google App Engine
This is Rietveld 408576698