Remove unwanted declaration of storage for NeedsAdjustAndMark<>.

Remove unwanted declaration of storage for NeedsAdjustAndMark<>.

This rolls back the change made in

 https://codereview.chromium.org/429793003/

We shouldn't have to do this if the class type has been fully
instantiated and "used". Traits used to direct compilation won't run
into this (as the expression will clearly have to be evaluated at
compile-time), but gtest usage of traits may end up evaluating their
predicate expressions in compiled code, thus requiring that the trait
has been instantiated in the compilation unit already. Declaring one
for all uses of NeedsAdjustAndMark<> is too strong, and isn't needed
really (now) -- retire, but avoid running into the issue for the
corresponding unit test.

R=
BUG=

Committed: https://crrev.com/7c64218640eb5047036dae700300e05d9c09f20d
Cr-Commit-Position: refs/heads/master@{#440618}

[sof, 2016-12-23 09:47:21]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 09:47:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2016-12-23 09:48:54]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2016-12-23 09:48:55]

please take a look.

[haraken, 2016-12-23 10:01:55]

LGTM

[commit-bot: I haz the power, 2016-12-23 11:31:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 11:31:32]

Dry run: This issue passed the CQ dry run.

[sof, 2016-12-23 11:39:53]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-12-23 11:40:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 11:43:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482493193788190, "parent_rev":
"dadc7d876025b5c7d87fa9d3a5920b706da56e7f", "commit_rev":
"b5dac32bc6baba40512e8d44d554f49b3d192b2e"}

[commit-bot: I haz the power, 2016-12-23 11:43:50]

Description was changed from

==========
Remove unwanted declaration of storage for NeedsAdjustAndMark<>.

This rolls back the change made in

 https://codereview.chromium.org/429793003/

We shouldn't have to do this if the class type has been fully
instantiated and "used". Traits used to direct compilation won't run
into this (as the expression will clearly have to be evaluated at
compile-time), but gtest usage of traits may end up evaluating their
predicate expressions in compiled code, thus requiring that the trait
has been instantiated in the compilation unit already. Declaring one
for all uses of NeedsAdjustAndMark<> is too strong, and isn't needed
really (now) -- retire, but avoid running into the issue for the
corresponding unit test.

R=
BUG=
==========

to

==========
Remove unwanted declaration of storage for NeedsAdjustAndMark<>.

This rolls back the change made in

 https://codereview.chromium.org/429793003/

We shouldn't have to do this if the class type has been fully
instantiated and "used". Traits used to direct compilation won't run
into this (as the expression will clearly have to be evaluated at
compile-time), but gtest usage of traits may end up evaluating their
predicate expressions in compiled code, thus requiring that the trait
has been instantiated in the compilation unit already. Declaring one
for all uses of NeedsAdjustAndMark<> is too strong, and isn't needed
really (now) -- retire, but avoid running into the issue for the
corresponding unit test.

R=
BUG=

Review-Url: https://codereview.chromium.org/2599643004
==========

[commit-bot: I haz the power, 2016-12-23 11:43:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-23 11:46:33]

Description was changed from

==========
Remove unwanted declaration of storage for NeedsAdjustAndMark<>.

This rolls back the change made in

 https://codereview.chromium.org/429793003/

We shouldn't have to do this if the class type has been fully
instantiated and "used". Traits used to direct compilation won't run
into this (as the expression will clearly have to be evaluated at
compile-time), but gtest usage of traits may end up evaluating their
predicate expressions in compiled code, thus requiring that the trait
has been instantiated in the compilation unit already. Declaring one
for all uses of NeedsAdjustAndMark<> is too strong, and isn't needed
really (now) -- retire, but avoid running into the issue for the
corresponding unit test.

R=
BUG=

Review-Url: https://codereview.chromium.org/2599643004
==========

to

==========
Remove unwanted declaration of storage for NeedsAdjustAndMark<>.

This rolls back the change made in

 https://codereview.chromium.org/429793003/

We shouldn't have to do this if the class type has been fully
instantiated and "used". Traits used to direct compilation won't run
into this (as the expression will clearly have to be evaluated at
compile-time), but gtest usage of traits may end up evaluating their
predicate expressions in compiled code, thus requiring that the trait
has been instantiated in the compilation unit already. Declaring one
for all uses of NeedsAdjustAndMark<> is too strong, and isn't needed
really (now) -- retire, but avoid running into the issue for the
corresponding unit test.

R=
BUG=

Committed: https://crrev.com/7c64218640eb5047036dae700300e05d9c09f20d
Cr-Commit-Position: refs/heads/master@{#440618}
==========

[commit-bot: I haz the power, 2016-12-23 11:46:34]

Patchset 1 (id:??) landed as
https://crrev.com/7c64218640eb5047036dae700300e05d9c09f20d
Cr-Commit-Position: refs/heads/master@{#440618}