Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2599643004: Remove unwanted declaration of storage for NeedsAdjustAndMark<>. (Closed)

Created:
3 years, 12 months ago by sof
Modified:
3 years, 12 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unwanted declaration of storage for NeedsAdjustAndMark<>. This rolls back the change made in https://codereview.chromium.org/429793003/ We shouldn't have to do this if the class type has been fully instantiated and "used". Traits used to direct compilation won't run into this (as the expression will clearly have to be evaluated at compile-time), but gtest usage of traits may end up evaluating their predicate expressions in compiled code, thus requiring that the trait has been instantiated in the compilation unit already. Declaring one for all uses of NeedsAdjustAndMark<> is too strong, and isn't needed really (now) -- retire, but avoid running into the issue for the corresponding unit test. R= BUG= Committed: https://crrev.com/7c64218640eb5047036dae700300e05d9c09f20d Cr-Commit-Position: refs/heads/master@{#440618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M third_party/WebKit/Source/platform/heap/GarbageCollected.h View 4 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sof
please take a look.
3 years, 12 months ago (2016-12-23 09:48:55 UTC) #4
haraken
LGTM
3 years, 12 months ago (2016-12-23 10:01:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599643004/1
3 years, 12 months ago (2016-12-23 11:40:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-23 11:43:51 UTC) #12
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 11:46:34 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c64218640eb5047036dae700300e05d9c09f20d
Cr-Commit-Position: refs/heads/master@{#440618}

Powered by Google App Engine
This is Rietveld 408576698